From ade8e633238040a6621a3e2fbab8dfeb43bc19a6 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 15 Aug 2026 14:19:38 +0900 Subject: docs(php-shim): drop the inaccurate fileperms TODO The comment claimed the port loses the file type bits that PHP's fileperms() reports. It does not: MetadataExt::mode() hands back the raw st_mode, the same value php_stat() returns for FS_PERMS, and both agree on directories, regular files and executables. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe-php-shim/src/fs.rs | 1 - 1 file changed, 1 deletion(-) (limited to 'crates/shirabe-php-shim/src') diff --git a/crates/shirabe-php-shim/src/fs.rs b/crates/shirabe-php-shim/src/fs.rs index c5a4bdf5..7bf36cde 100644 --- a/crates/shirabe-php-shim/src/fs.rs +++ b/crates/shirabe-php-shim/src/fs.rs @@ -793,7 +793,6 @@ pub fn chmod(path: impl AsRef, mode: u32) -> bool { pub fn fileperms(path: impl AsRef) -> Result { use std::os::unix::fs::MetadataExt; - // TODO(php-semantics): PHP returns the full st_mode (file type bits included). std::fs::metadata(path.as_ref()).map(|m| m.mode()) } -- cgit v1.3.1-4-g156e