From 6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 2 Aug 2026 16:16:51 +0900 Subject: refactor(php-shim): introduce PhpClass for reporting PHP class names Rust has no runtime class name, so `Command::get_class` existed purely to let each command hand back its PHP class name, supplied through the two-argument variant of `delegate_command_trait_impls_to_inner!` at the impl site. Replace it with a general `PhpClass` trait plus an `impl_php_class!` macro, so the name is stated once next to the type definition and the mechanism is reusable outside commands. `Command` gains `PhpClass` as a supertrait and drops `get_class`, and `VcsDriverKind`'s hand-rolled `php_class_name` table moves onto the trait. Behavior is unchanged: the same class-name strings are reported, and the base command state still panics when asked for a name it cannot supply. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe-php-shim/src/lib.rs | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) (limited to 'crates/shirabe-php-shim') diff --git a/crates/shirabe-php-shim/src/lib.rs b/crates/shirabe-php-shim/src/lib.rs index 93b2e430..ab904a46 100644 --- a/crates/shirabe-php-shim/src/lib.rs +++ b/crates/shirabe-php-shim/src/lib.rs @@ -284,6 +284,33 @@ impl AsAny for T { } } +/// A ported type that reports the name of the PHP class it was ported from. +/// +/// Rust has no runtime class name, so the PHP class name is stated once at the type's +/// definition through [`impl_php_class!`]. Implement this wherever the port needs what PHP's +/// `\get_class()` would report. +pub trait PhpClass { + /// The fully-qualified class name, e.g. `Composer\Command\InstallCommand`. + fn php_class_name(&self) -> &'static str; +} + +/// Implements [`PhpClass`] for a ported type, given the fully-qualified name of the PHP +/// class it was ported from. +/// +/// ```ignore +/// impl_php_class!(InstallCommand, r"Composer\Command\InstallCommand"); +/// ``` +#[macro_export] +macro_rules! impl_php_class { + ($ty:ty, $class_name:literal) => { + impl $crate::PhpClass for $ty { + fn php_class_name(&self) -> &'static str { + $class_name + } + } + }; +} + impl From for PhpMixed { fn from(value: i64) -> Self { PhpMixed::Int(value) -- cgit v1.3.1