From 3a388b98a9aa6a14b1c7f7dc909c109cf9837800 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 16 Aug 2026 00:59:54 +0900 Subject: refactor: narrow pub(crate) items to private Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe-symfony-console/src/helper/helper.rs | 2 +- crates/shirabe-symfony-console/src/helper/question_helper.rs | 6 +++--- crates/shirabe-symfony-console/src/helper/table_cell.rs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'crates/shirabe-symfony-console/src/helper') diff --git a/crates/shirabe-symfony-console/src/helper/helper.rs b/crates/shirabe-symfony-console/src/helper/helper.rs index c92b7cb1..4f0447f3 100644 --- a/crates/shirabe-symfony-console/src/helper/helper.rs +++ b/crates/shirabe-symfony-console/src/helper/helper.rs @@ -8,7 +8,7 @@ use shirabe_symfony_string::unicode_string::UnicodeString; /// Helper is the base class for all helper classes. #[derive(Debug, Default)] pub struct Helper { - pub(crate) helper_set: Option>>, + helper_set: Option>>, } impl Helper { diff --git a/crates/shirabe-symfony-console/src/helper/question_helper.rs b/crates/shirabe-symfony-console/src/helper/question_helper.rs index c051fff2..6e28049e 100644 --- a/crates/shirabe-symfony-console/src/helper/question_helper.rs +++ b/crates/shirabe-symfony-console/src/helper/question_helper.rs @@ -24,7 +24,7 @@ use shirabe_symfony_string::s; /// The QuestionHelper class provides helpers to interact with the user. #[derive(Debug, Default)] pub struct QuestionHelper { - pub(crate) inner: Helper, + inner: Helper, /// @var resource|null input_stream: Option, @@ -352,7 +352,7 @@ impl QuestionHelper { } /// Outputs the question prompt. - pub(crate) fn write_prompt( + fn write_prompt( &self, output: std::rc::Rc>, question: &impl QuestionInterface, @@ -403,7 +403,7 @@ impl QuestionHelper { } /// Outputs an error message. - pub(crate) fn write_error( + fn write_error( &self, output: std::rc::Rc>, error: &shirabe_php_shim::Exception, diff --git a/crates/shirabe-symfony-console/src/helper/table_cell.rs b/crates/shirabe-symfony-console/src/helper/table_cell.rs index fdcda7b8..3081c26a 100644 --- a/crates/shirabe-symfony-console/src/helper/table_cell.rs +++ b/crates/shirabe-symfony-console/src/helper/table_cell.rs @@ -14,7 +14,7 @@ pub enum TableCellOption { #[derive(Debug, Clone)] pub struct TableCell { - pub(crate) value: String, + value: String, options: IndexMap, } -- cgit v1.3.1-4-g156e