From efe5bdb1987411a473d4af15451a376d20928245 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Fri, 12 Jun 2026 03:19:34 +0900
Subject: refactor(php-shim): replace literal sprintf calls with format!

Convert every sprintf() call with a compile-time literal format string to
format!, implementing Display for PhpMixed (delegating to php_to_string) so
PhpMixed values render with PHP string semantics through {}. Also merge the
format!-wrapped and conditional-literal dynamic sites into single format!
calls. Genuinely runtime format strings (table styles, configurable error
messages, command synopsis, progress-bar modifiers, regex-built messages)
still go through sprintf.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/advisory/auditor.rs | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)

(limited to 'crates/shirabe/src/advisory/auditor.rs')

diff --git a/crates/shirabe/src/advisory/auditor.rs b/crates/shirabe/src/advisory/auditor.rs
index c12e131..c7558f4 100644
--- a/crates/shirabe/src/advisory/auditor.rs
+++ b/crates/shirabe/src/advisory/auditor.rs
@@ -551,16 +551,14 @@ impl Auditor {
         packages: &[CompletePackageInterfaceHandle],
         format: &str,
     ) -> Result<()> {
-        io.write_error(&sprintf(
-            "<error>Found %d abandoned package%s:</error>",
-            &[
-                PhpMixed::Int(packages.len() as i64),
-                PhpMixed::String(if packages.len() > 1 {
-                    "s".to_string()
-                } else {
-                    String::new()
-                }),
-            ],
+        io.write_error(&format!(
+            "<error>Found {} abandoned package{}:</error>",
+            PhpMixed::Int(packages.len() as i64),
+            PhpMixed::String(if packages.len() > 1 {
+                "s".to_string()
+            } else {
+                String::new()
+            }),
         ));
 
         if format == Self::FORMAT_PLAIN {
@@ -570,12 +568,10 @@ impl Auditor {
                 } else {
                     "No replacement was suggested".to_string()
                 };
-                io.write_error(&sprintf(
-                    "%s is abandoned. %s.",
-                    &[
-                        PhpMixed::String(self.get_package_name_with_link(pkg.clone().into())),
-                        PhpMixed::String(replacement),
-                    ],
+                io.write_error(&format!(
+                    "{} is abandoned. {}.",
+                    PhpMixed::String(self.get_package_name_with_link(pkg.clone().into())),
+                    PhpMixed::String(replacement),
                 ));
             }
 
-- 
cgit v1.3.1