From 0b48f4a46d24248e4c012ef37d25b5963c27a78c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 23 Aug 2026 12:43:10 +0900 Subject: fix(fs): carry file_get_contents results as bytes file_get_contents() and file_get_contents_with_max_length() return Vec instead of a from_utf8_lossy'd String. Call sites whose consumer takes a &str still convert lossily and are marked TODO(bytes). file_get_contents_with_max_length() now reads at most the requested number of bytes instead of the whole file. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/autoload/autoload_generator.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/autoload/autoload_generator.rs') diff --git a/crates/shirabe/src/autoload/autoload_generator.rs b/crates/shirabe/src/autoload/autoload_generator.rs index 55124467..3abf3453 100644 --- a/crates/shirabe/src/autoload/autoload_generator.rs +++ b/crates/shirabe/src/autoload/autoload_generator.rs @@ -556,8 +556,11 @@ return array( // carry over existing autoload.php's suffix if possible and none is configured if suffix.is_none() && Filesystem::is_readable(&format!("{}/autoload.php", vendor_path)) { - let content = - file_get_contents(format!("{}/autoload.php", vendor_path)).unwrap_or_default(); + // TODO(bytes): preg_match matches over a &str. + let content = String::from_utf8_lossy( + &file_get_contents(format!("{}/autoload.php", vendor_path)).unwrap_or_default(), + ) + .into_owned(); if let Some(matches) = preg_match(php_regex!("{ComposerAutoloaderInit([^:\\s]+)::}"), &content) { -- cgit v1.3.1-4-g156e