From cd25c3e193f05a5e89bca2a1c706c85fdc9c9155 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 02:13:59 +0900 Subject: refactor(repository): make read methods fallible and take &mut self Change RepositoryInterface and WritableRepositoryInterface read methods (find_package, find_packages, get_packages, load_packages, search, get_providers, get_canonical_packages) to take &mut self and return anyhow::Result, so lazy-loading repositories such as ComposerRepository can perform fallible I/O and mutate internal state on access. Update all implementors and call sites to propagate the Result and pass mutable references. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/autoload/autoload_generator.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src/autoload/autoload_generator.rs') diff --git a/crates/shirabe/src/autoload/autoload_generator.rs b/crates/shirabe/src/autoload/autoload_generator.rs index 9647a8d..c36125f 100644 --- a/crates/shirabe/src/autoload/autoload_generator.rs +++ b/crates/shirabe/src/autoload/autoload_generator.rs @@ -125,7 +125,7 @@ impl AutoloadGenerator { pub fn dump( &mut self, config: &Config, - local_repo: &dyn InstalledRepositoryInterface, + local_repo: &mut dyn InstalledRepositoryInterface, root_package: RootPackageInterfaceHandle, installation_manager: &mut InstallationManager, target_dir: &str, @@ -244,12 +244,12 @@ impl AutoloadGenerator { ); // Collect information from all packages. - let dev_package_names = local_repo.get_dev_package_names(); let package_map = self.build_package_map( installation_manager, root_package.clone(), - local_repo.get_canonical_packages(), + local_repo.get_canonical_packages()?, )?; + let dev_package_names = local_repo.get_dev_package_names(); let filtered_dev_packages: PhpMixed = if self.dev_mode.unwrap_or(false) { // if dev mode is enabled, then we do not filter any dev packages out so disable this entirely PhpMixed::Bool(false) -- cgit v1.3.1