From 0b48f4a46d24248e4c012ef37d25b5963c27a78c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 23 Aug 2026 12:43:10 +0900 Subject: fix(fs): carry file_get_contents results as bytes file_get_contents() and file_get_contents_with_max_length() return Vec instead of a from_utf8_lossy'd String. Call sites whose consumer takes a &str still convert lossily and are marked TODO(bytes). file_get_contents_with_max_length() now reads at most the requested number of bytes instead of the whole file. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/cache.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'crates/shirabe/src/cache.rs') diff --git a/crates/shirabe/src/cache.rs b/crates/shirabe/src/cache.rs index a8e4fb26..269a31ef 100644 --- a/crates/shirabe/src/cache.rs +++ b/crates/shirabe/src/cache.rs @@ -136,7 +136,11 @@ impl Cache { crate::io::DEBUG, ); - return file_get_contents(&full_path); + // TODO(bytes): the payload is handed back to callers as a String, so a cache + // entry that is not valid UTF-8 is corrupted by from_utf8_lossy. + return file_get_contents(&full_path) + .map(|c| String::from_utf8_lossy(&c).into_owned()) + .ok(); } } -- cgit v1.3.1-4-g156e