From 20f9787cda5b846c730cff97a4c7a3777ff3414a Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 24 Aug 2026 21:07:26 +0900 Subject: refactor(silencer): stop guarding work that stays inside Rust Silencer only lowers the PHP error_reporting() level and re-throws whatever the guarded work raises. A region that never reaches the PHP runtime has no level to lower and emits no diagnostic on failure, so wrapping it is indistinguishable from running it unguarded. The pair kept in Application::hint_common_errors brackets a getComposer() call, which loads installed plugins and dispatches PluginEvents::INIT. Co-Authored-By: Claude Opus 5 --- crates/shirabe/src/cache.rs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/cache.rs') diff --git a/crates/shirabe/src/cache.rs b/crates/shirabe/src/cache.rs index 269a31ef..ececa9fd 100644 --- a/crates/shirabe/src/cache.rs +++ b/crates/shirabe/src/cache.rs @@ -4,7 +4,6 @@ use crate::io::IOInterface; use crate::io::IOInterfaceImmutable; use crate::util::Filesystem; use crate::util::Platform; -use crate::util::Silencer; use chrono::Utc; use shirabe_php_shim::{ ErrorException, bin2hex, clearstatcache, date_format_to_strftime, dirname, disk_free_space, @@ -105,9 +104,7 @@ impl Cache { self.enabled = Some(true); if !self.read_only - && ((!is_dir(&self.root) - && !Silencer::call(|| Ok(mkdir(&self.root, 0o777, true).is_ok())) - .unwrap_or(false)) + && ((!is_dir(&self.root) && mkdir(&self.root, 0o777, true).is_err()) || !is_writable(&self.root)) { self.io.write_error(&format!( @@ -270,7 +267,7 @@ impl Cache { Ok(_) => { // fallback in case the above failed due to incorrect ownership // see https://github.com/composer/composer/issues/4070 - Silencer::call(|| Ok(shirabe_php_shim::touch(&full_path)))?; + shirabe_php_shim::touch(&full_path); } Err(payload) => std::panic::resume_unwind(payload), } -- cgit v1.3.1-4-g156e