From e093b2be1c333e67c96aebb0a5291bea9ae3d6db Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 18 Aug 2026 01:57:02 +0900 Subject: refactor(preg): drop the offset argument from preg_match Every call site but one passed offset 0. The remaining one, the UTF-8 chunking loop in Application, slices the subject instead: its pattern has no anchor or lookaround, so matching a suffix is equivalent to starting the search at that offset. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/cache.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/cache.rs') diff --git a/crates/shirabe/src/cache.rs b/crates/shirabe/src/cache.rs index 80085ff9..919d0ac2 100644 --- a/crates/shirabe/src/cache.rs +++ b/crates/shirabe/src/cache.rs @@ -9,7 +9,7 @@ use chrono::Utc; use shirabe_php_shim::{ ErrorException, bin2hex, clearstatcache, date_format_to_strftime, dirname, disk_free_space, file_exists, file_get_contents, file_put_contents, filemtime, function_exists, hash_file, - is_dir, is_writable, mkdir, php_regex, preg_match2, preg_replace, random_bytes, random_int, + is_dir, is_writable, mkdir, php_regex, preg_match, preg_replace, random_bytes, random_int, rename, time, unlink, }; use shirabe_symfony_finder::Finder; @@ -94,10 +94,9 @@ impl Cache { } pub fn is_usable(path: &str) -> bool { - preg_match2( + preg_match( php_regex!(r"{(^|[\\\\/])(\$null|nul|NUL|/dev/null)([\\\\/]|$)}"), path, - 0, ) .is_none() } @@ -188,12 +187,11 @@ impl Cache { true, crate::io::DEBUG, ); - if let Some(m) = preg_match2( + if let Some(m) = preg_match( php_regex!( r"{^file_put_contents\(\): Only ([0-9]+) of ([0-9]+) bytes written}" ), e.get_message(), - 0, ) { // Remove partial file. unlink(&temp_file_name); -- cgit v1.3.1-4-g156e