From efec43b3b8827820cf35fe1b73d8e33f5fe84eb4 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 01:16:50 +0900 Subject: refactor: auto-fix clippy warnings --- crates/shirabe/src/command/archive_command.rs | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) (limited to 'crates/shirabe/src/command/archive_command.rs') diff --git a/crates/shirabe/src/command/archive_command.rs b/crates/shirabe/src/command/archive_command.rs index cd5fa04..1a043af 100644 --- a/crates/shirabe/src/command/archive_command.rs +++ b/crates/shirabe/src/command/archive_command.rs @@ -40,6 +40,12 @@ pub struct ArchiveCommand { base_command_data: BaseCommandData, } +impl Default for ArchiveCommand { + fn default() -> Self { + Self::new() + } +} + impl ArchiveCommand { const FORMATS: &'static [&'static str] = &["tar", "tar.gz", "tar.bz2", "zip"]; @@ -201,6 +207,7 @@ impl BaseCommand for ArchiveCommand { } impl ArchiveCommand { + #[allow(clippy::too_many_arguments, reason = "to keep PHP signature")] pub fn archive( &mut self, io: std::rc::Rc>, @@ -239,7 +246,7 @@ impl ArchiveCommand { Some(process), ))); owned_archive_manager = - factory.create_archive_manager(&*config.borrow(), &download_manager, &loop_)?; + factory.create_archive_manager(&config.borrow(), &download_manager, &loop_)?; &mut owned_archive_manager }; @@ -299,12 +306,7 @@ impl ArchiveCommand { let repository_manager = repository_manager.borrow(); let local_repo = repository_manager.get_local_repository(); let mut repos: Vec = vec![local_repo]; - repos.extend( - repository_manager - .get_repositories() - .iter() - .map(|r| r.clone()), - ); + repos.extend(repository_manager.get_repositories().iter().cloned()); repo = CompositeRepository::new(repos); min_stability = composer.get_package().get_minimum_stability().to_string(); } else { @@ -368,7 +370,7 @@ impl ArchiveCommand { None, shirabe_php_shim::PhpMixed::Bool(true), )?; - let p = best.unwrap_or_else(|| packages.into_iter().next().unwrap().into()); + let p = best.unwrap_or_else(|| packages.into_iter().next().unwrap()); io.write_error(&format!( "Found multiple matches, selected {}.", @@ -378,8 +380,7 @@ impl ArchiveCommand { io.write_error("Please use a more specific constraint to pick a different package."); p } else if packages.len() == 1 { - let p: crate::package::PackageInterfaceHandle = - packages.into_iter().next().unwrap().into(); + let p: crate::package::PackageInterfaceHandle = packages.into_iter().next().unwrap(); io.write_error(&format!( "Found an exact match {}.", p.get_pretty_string() -- cgit v1.3.1