From a9f19862350c6fd3592d93515d869ffe07ecb399 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 4 Jun 2026 21:08:22 +0900 Subject: feat: resolve trivial todo!() sites with existing constructors Replace todo!("VersionParser::new()") with VersionParser::new() at 6 call sites (array_loader, base_command, create_project_command, vcs_repository, http_downloader x2) and EventDispatcher::io_clone with self.io.clone(). All targets already exist on their types. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/command/base_command.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'crates/shirabe/src/command/base_command.rs') diff --git a/crates/shirabe/src/command/base_command.rs b/crates/shirabe/src/command/base_command.rs index 6b673ed..f806854 100644 --- a/crates/shirabe/src/command/base_command.rs +++ b/crates/shirabe/src/command/base_command.rs @@ -643,8 +643,7 @@ impl BaseCommand for C { &self, requirements: Vec, ) -> Result>> { - // TODO(phase-b): VersionParser has no public `new` yet - let parser: VersionParser = todo!("VersionParser::new()"); + let parser: VersionParser = VersionParser::new(); parser.parse_name_version_pairs(requirements) } -- cgit v1.3.1