From ee5d0e84c2060f10c20a4b3e519bf0f928fd170d Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 5 Aug 2026 02:48:41 +0900 Subject: feat(plugin): discover and list plugin-provided commands Port Application::getPluginCommands: resolve the local composer with plugins force-enabled, fall back to Factory::createGlobal, and collect commands from CommandProvider capability adapters. PhpCommandProxy now mirrors name/description/aliases/hidden over RPC so `list` output matches upstream; input definitions remain TODO(plugin). PhpClass::php_class_name returns an owned String because PHP-backed proxies only know their class at runtime (the override-skip warning prints get_class). CommandProvider::getCommands hands out shared Rc handles since the commands are stored in the application. Factory::createGlobal now propagates createConfig errors instead of swallowing them, and Application::getComposer only catches the exception classes upstream catches, so a ParsingException reaches doRun's GithubActionError path as in Composer. Co-Authored-By: Claude Fable 5 --- crates/shirabe/src/command/base_command.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/command/base_command.rs') diff --git a/crates/shirabe/src/command/base_command.rs b/crates/shirabe/src/command/base_command.rs index 77850e9e..f9682de9 100644 --- a/crates/shirabe/src/command/base_command.rs +++ b/crates/shirabe/src/command/base_command.rs @@ -283,7 +283,7 @@ impl Command for BaseCommandData { } impl PhpClass for BaseCommandData { - fn php_class_name(&self) -> &'static str { + fn php_class_name(&self) -> String { // Forwards to the base state's panicking implementation; concrete commands supply // their own class name through `impl_php_class!`. self.inner.php_class_name() @@ -852,7 +852,7 @@ pub fn base_command_initialize( crate::factory::DisablePlugins::None }; let composer = if composer.is_none() { - Factory::create_global(io.clone(), disable_plugins_kind, disable_scripts) + Factory::create_global(io.clone(), disable_plugins_kind, disable_scripts)? } else { composer }; -- cgit v1.3.1