From 1e7aabcae1b2139aa20a80fbf303c74388933f55 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 15:16:07 +0900 Subject: fix(array-dumper): emit package links and require Link pretty constraint Resolve the phase-b TODO that left the supported-link-types loop as dead code (links were always an empty Vec), so requires/conflicts/provides/ replaces/require-dev are dumped again via PackageInterface::get_links_for_type, matching the PHP magic-call loop. Every Link in production is constructed with a pretty constraint (all ArrayLoader/AliasPackage/PlatformRepository/InstalledRepository sites pass one), so make Link::pretty_constraint a required String instead of Option. get_pretty_constraint() now returns &str directly rather than anyhow::Result<&str>, dropping the unreachable UnexpectedValueException guard, and all call sites are updated. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/command/base_dependency_command.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/src/command/base_dependency_command.rs') diff --git a/crates/shirabe/src/command/base_dependency_command.rs b/crates/shirabe/src/command/base_dependency_command.rs index 5dfb13f..4f929c8 100644 --- a/crates/shirabe/src/command/base_dependency_command.rs +++ b/crates/shirabe/src/command/base_dependency_command.rs @@ -357,11 +357,7 @@ pub trait BaseDependencyCommand: BaseCommand { name_with_link, version, link.get_description().to_string(), - format!( - "{} ({})", - link.get_target(), - link.get_pretty_constraint().unwrap_or("") - ), + format!("{} ({})", link.get_target(), link.get_pretty_constraint()), ]); if let Some(children_vec) = children { queue.extend(children_vec); @@ -438,7 +434,7 @@ pub trait BaseDependencyCommand: BaseCommand { prev_color, link.get_target(), prev_color, - link.get_pretty_constraint().unwrap_or("") + link.get_pretty_constraint(), ); let circular_warn = if children.is_none() { "(circular dependency aborted here)" -- cgit v1.3.1