From 81b9fc9d92bb74aa8428ae4db39bd84e8c16095c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 18:34:54 +0900 Subject: refactor(php-shim): drop Box wrapping from PhpMixed List/Array The List and Array variants of PhpMixed boxed their elements unnecessarily. Store PhpMixed values directly and update all callers accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/command/base_dependency_command.rs | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'crates/shirabe/src/command/base_dependency_command.rs') diff --git a/crates/shirabe/src/command/base_dependency_command.rs b/crates/shirabe/src/command/base_dependency_command.rs index 98a2622..6a892e8 100644 --- a/crates/shirabe/src/command/base_dependency_command.rs +++ b/crates/shirabe/src/command/base_dependency_command.rs @@ -111,7 +111,6 @@ pub trait BaseDependencyCommand: BaseCommand { .cloned() .unwrap_or_default() .into_iter() - .map(|(k, v)| (k, *v)) .collect(); repos.push(crate::repository::RepositoryInterfaceHandle::new( PlatformRepository::new(vec![], platform_overrides)?, @@ -379,13 +378,7 @@ pub trait BaseDependencyCommand: BaseCommand { } let table_as_mixed: Vec = table .into_iter() - .map(|row| { - PhpMixed::List( - row.into_iter() - .map(|s| Box::new(PhpMixed::String(s))) - .collect(), - ) - }) + .map(|row| PhpMixed::List(row.into_iter().map(PhpMixed::String).collect())) .collect(); self.render_table(table_as_mixed, output); } -- cgit v1.3.1