From 1921f173ea219cb4b25847294d2d3fa465550fbb Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 25 May 2026 00:58:20 +0900 Subject: refactor(package): introduce Rc> handles for packages PHP packages have reference semantics, so introduce shared-ownership handles over an AnyPackage enum (PackageInterfaceHandle and friends) and replace Box throughout. Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/shirabe/src/command/bump_command.rs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/command/bump_command.rs') diff --git a/crates/shirabe/src/command/bump_command.rs b/crates/shirabe/src/command/bump_command.rs index 0b9727f..3299f85 100644 --- a/crates/shirabe/src/command/bump_command.rs +++ b/crates/shirabe/src/command/bump_command.rs @@ -251,13 +251,14 @@ impl BumpCommand { None => continue, Some(p) => p, }; - while let Some(alias) = package.as_any().downcast_ref::() { - // TODO(phase-b): get_alias_of returns &dyn BasePackage; cloning into Box - // requires clone_box on BasePackage applied to a borrowed ref. - package = alias.get_alias_of().clone_box(); + while let Some(alias) = package.as_alias() { + package = alias.get_alias_of().into(); } - let bumped = bumper.bump_requirement(link.get_constraint(), package.as_ref())?; + let bumped = bumper.bump_requirement( + link.get_constraint(), + package.as_rc().borrow().as_package_interface(), + )?; if bumped == current_constraint { continue; -- cgit v1.3.1