From 1e7aabcae1b2139aa20a80fbf303c74388933f55 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 15:16:07 +0900 Subject: fix(array-dumper): emit package links and require Link pretty constraint Resolve the phase-b TODO that left the supported-link-types loop as dead code (links were always an empty Vec), so requires/conflicts/provides/ replaces/require-dev are dumped again via PackageInterface::get_links_for_type, matching the PHP magic-call loop. Every Link in production is constructed with a pretty constraint (all ArrayLoader/AliasPackage/PlatformRepository/InstalledRepository sites pass one), so make Link::pretty_constraint a required String instead of Option. get_pretty_constraint() now returns &str directly rather than anyhow::Result<&str>, dropping the unreachable UnexpectedValueException guard, and all call sites are updated. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/command/check_platform_reqs_command.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/src/command/check_platform_reqs_command.rs') diff --git a/crates/shirabe/src/command/check_platform_reqs_command.rs b/crates/shirabe/src/command/check_platform_reqs_command.rs index 5225f7e..05f7e9b 100644 --- a/crates/shirabe/src/command/check_platform_reqs_command.rs +++ b/crates/shirabe/src/command/check_platform_reqs_command.rs @@ -287,9 +287,7 @@ impl CheckPlatformReqsCommand { ); failed_req.insert( "constraint".to_string(), - Box::new(PhpMixed::String( - link.get_pretty_constraint().unwrap_or("").to_string(), - )), + Box::new(PhpMixed::String(link.get_pretty_constraint().to_string())), ); row.insert( "failed_requirement".to_string(), @@ -327,7 +325,7 @@ impl CheckPlatformReqsCommand { link.get_source(), link.get_description(), link.get_target(), - link.get_pretty_constraint().unwrap_or(""), + link.get_pretty_constraint(), )) } else { PhpMixed::String(String::new()) -- cgit v1.3.1