From 432472808051cb4f1bb9517b858dbc810aaa5a63 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 25 Jul 2026 16:16:33 +0900 Subject: refactor: replace redundant clones with moves Co-Authored-By: Claude Opus 5 --- crates/shirabe/src/command/diagnose_command.rs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'crates/shirabe/src/command/diagnose_command.rs') diff --git a/crates/shirabe/src/command/diagnose_command.rs b/crates/shirabe/src/command/diagnose_command.rs index ac15e1d1..9d0ee6f4 100644 --- a/crates/shirabe/src/command/diagnose_command.rs +++ b/crates/shirabe/src/command/diagnose_command.rs @@ -103,7 +103,7 @@ impl Command for DiagnoseCommand { let config: std::rc::Rc>; if let Some(ref mut c) = composer { let c = crate::composer::composer_full(c); - config = c.get_config().clone(); + config = c.get_config(); let command_event = CommandEvent::new6( PluginEvents::COMMAND, @@ -187,7 +187,7 @@ impl Command for DiagnoseCommand { crate::repository::FindPackageConstraint::String("*".to_string()), )? .unwrap(); - let mut php_version = php_pkg.get_pretty_version().to_string(); + let mut php_version = php_pkg.get_pretty_version(); if let Some(cp) = php_pkg.as_complete() && str_contains(&cp.get_description().unwrap_or_default(), "overridden") { @@ -986,11 +986,8 @@ impl DiagnoseCommand { if version != "@package_version@" { let version_parser = VersionParser::new(); let normalized_version = version_parser.normalize(&version, None)?; - let root_pkg = RootPackage::new( - "composer/composer".to_string(), - normalized_version, - version.clone(), - ); + let root_pkg = + RootPackage::new("composer/composer".to_string(), normalized_version, version); packages.push(crate::package::RootPackageHandle::from_root_package(root_pkg).into()); } let mut repo_config: IndexMap = IndexMap::new(); -- cgit v1.3.1