From 6a7e64d04a8b0ad932169df43e2d93efe8ceedf8 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 18 Aug 2026 07:18:07 +0900 Subject: fix: propagate ported exceptions instead of flattening them `ProcessExecutor::execute_args` existed only to turn `execute`'s `anyhow::Result` into an exit code of 1, so every one of its ~87 call sites silently took the "command failed" branch on an error PHP would have thrown. It is gone; callers use `execute` and propagate with `?`. Where the enclosing function had no `Result` to propagate into, its signature grew one, up to and including `Git::get_version`, `Svn::binary_version`, `GitHub`/`GitLab`/`Bitbucket::authorize_oauth`, `InitCommand::get_git_config` and `DiagnoseCommand::check_git`. The VCS drivers had the same problem in the other direction: their `get_contents` returned `Result>`, a type too narrow for the PHP method, which lets any Throwable out of the `catch (TransportException $e)` block. Every non-transport error was therefore rewritten into a `TransportException` with code 0, which the callers switch on. They now return `anyhow::Result>>`: the outer `Result` carries what PHP does not catch, the inner one the exception the drivers handle. That signature also restores `GitLabDriver::getContents`: the 400/401 `TransportException`s it raises to force authentication are thrown inside its own `try` block and handled by its own `catch`, but the port returned them straight to the caller, so the authentication flow behind them never ran. `impl_php_exception!` gains `From> for anyhow::Error` so a caught exception can be re-propagated with `?`. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/command/diagnose_command.rs | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) (limited to 'crates/shirabe/src/command/diagnose_command.rs') diff --git a/crates/shirabe/src/command/diagnose_command.rs b/crates/shirabe/src/command/diagnose_command.rs index 860c058b..9c1fb2f8 100644 --- a/crates/shirabe/src/command/diagnose_command.rs +++ b/crates/shirabe/src/command/diagnose_command.rs @@ -119,9 +119,11 @@ impl DiagnoseCommand { Ok(PhpMixed::Bool(true)) } - fn check_git(&self) -> String { + fn check_git(&self) -> anyhow::Result { if !shirabe_php_rpc::get_diagnostics().function_exists("proc_open") { - return "proc_open is not available, git cannot be used".to_string(); + return Ok( + "proc_open is not available, git cannot be used".to_string(), + ); } let mut output = String::new(); @@ -141,24 +143,27 @@ impl DiagnoseCommand { None, ); if strtolower(&trim(&output, Some(" \t\n\r\0\u{0B}"))) == "always" { - return "Your git color.ui setting is set to always, this is known to create issues. Use \"git config --global color.ui true\" to set it correctly.".to_string(); + return Ok("Your git color.ui setting is set to always, this is known to create issues. Use \"git config --global color.ui true\" to set it correctly.".to_string()); } let process = self.process.borrow(); - let git_version = Git::get_version(process.as_ref().unwrap()); + let git_version = Git::get_version(process.as_ref().unwrap())?; let git_version = match git_version { Some(v) => v, - None => return "No git process found".to_string(), + None => return Ok("No git process found".to_string()), }; if version_compare("2.24.0", &git_version, CmpOp::Gt) { - return format!( + return Ok(format!( "Your git version ({}) is too old and possibly will cause issues. Please upgrade to git 2.24 or above", git_version - ); + )); } - format!("OK git version {}", git_version) + Ok(format!( + "OK git version {}", + git_version + )) } fn check_http( @@ -1325,7 +1330,7 @@ impl Command for DiagnoseCommand { self.output_result(r); io.write_no_newline("Checking git settings: "); - let r = self.check_git(); + let r = self.check_git()?; self.output_result(PhpMixed::String(r)); io.write_no_newline("Checking http connectivity to packagist: "); -- cgit v1.3.1-4-g156e