From 704ba2d87733657dea852fa697fc6d23a961a71b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 17 Aug 2026 04:18:59 +0900 Subject: refactor(preg): replace Preg::split*() with shim preg_split*() preg_split2()'s limit was always -1 and its flags were always either 0 or PREG_SPLIT_DELIM_CAPTURE alone, so both arguments are gone: the shim now exposes preg_split() and preg_split_delim_capture() over a shared preg_split_impl(). That leaves Preg::split()/split4() as bare pass-throughs, so callers use the shim functions directly and the wrappers are dropped along with the now-unreferenced PREG_SPLIT_* constants. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/command/global_command.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/command/global_command.rs') diff --git a/crates/shirabe/src/command/global_command.rs b/crates/shirabe/src/command/global_command.rs index af25eb29..21375141 100644 --- a/crates/shirabe/src/command/global_command.rs +++ b/crates/shirabe/src/command/global_command.rs @@ -9,7 +9,9 @@ use crate::factory::Factory; use crate::util::Filesystem; use crate::util::Platform; use shirabe_pcre::Preg; -use shirabe_php_shim::{LogicException, RuntimeException, chdir, impl_php_class, php_regex}; +use shirabe_php_shim::{ + LogicException, RuntimeException, chdir, impl_php_class, php_regex, preg_split, +}; use shirabe_symfony_console::command::Command; use shirabe_symfony_console::completion::CompletionInput; use shirabe_symfony_console::completion::{CompletionSuggestions, StringOrSuggestion}; @@ -223,7 +225,7 @@ impl Command for GlobalCommand { input: std::rc::Rc>, output: std::rc::Rc>, ) -> anyhow::Result { - let tokens = Preg::split( + let tokens = preg_split( php_regex!(r"{\s+}"), &Self::input_to_string(&*input.borrow())?, ); -- cgit v1.3.1-4-g156e