From f1af14b1cc503ac20f56a79a96c7780d02bdfe75 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Wed, 24 Jun 2026 03:56:26 +0900
Subject: fix(console): make Command/BaseCommand methods take &self

The Command trait and Composer's BaseCommand took &mut self, so dispatch
held a borrow_mut on the command's RefCell for the whole call. A command
re-entering itself (e.g. the help command describing itself) then panicked
with "RefCell already borrowed".

All Command/BaseCommand methods now take &self and the command state is
interior-mutable (Cell/RefCell). Shared borrows coexist, so re-entrant
describe paths no longer conflict. Getters that returned references now
return Ref guards; the descriptor describe_* methods take &dyn Command;
mixin accessors return Ref/RefMut.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/command/global_command.rs | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

(limited to 'crates/shirabe/src/command/global_command.rs')

diff --git a/crates/shirabe/src/command/global_command.rs b/crates/shirabe/src/command/global_command.rs
index 0645b3a..aed142c 100644
--- a/crates/shirabe/src/command/global_command.rs
+++ b/crates/shirabe/src/command/global_command.rs
@@ -43,7 +43,7 @@ impl Default for GlobalCommand {
 
 impl GlobalCommand {
     pub fn new() -> Self {
-        let mut command = GlobalCommand {
+        let command = GlobalCommand {
             base_command_data: BaseCommandData::new(None),
         };
         command
@@ -78,7 +78,7 @@ impl GlobalCommand {
     }
 
     fn prepare_subcommand_input(
-        &mut self,
+        &self,
         input: Rc<RefCell<dyn InputInterface>>,
         quiet: bool,
     ) -> Result<StringInput> {
@@ -127,7 +127,7 @@ impl GlobalCommand {
 }
 
 impl Command for GlobalCommand {
-    fn configure(&mut self) -> anyhow::Result<()> {
+    fn configure(&self) -> anyhow::Result<()> {
         self.set_name("global")?;
         self.set_description("Allows running commands in the global composer dir ($COMPOSER_HOME)");
         self.set_definition(&[
@@ -164,7 +164,7 @@ impl Command for GlobalCommand {
     }
 
     fn run(
-        &mut self,
+        &self,
         input: Rc<RefCell<dyn InputInterface>>,
         output: Rc<RefCell<dyn OutputInterface>>,
     ) -> anyhow::Result<i64> {
@@ -191,7 +191,7 @@ impl Command for GlobalCommand {
     }
 
     fn initialize(
-        &mut self,
+        &self,
         input: Rc<RefCell<dyn InputInterface>>,
         output: Rc<RefCell<dyn OutputInterface>>,
     ) -> anyhow::Result<()> {
@@ -202,10 +202,10 @@ impl Command for GlobalCommand {
 }
 
 impl BaseCommand for GlobalCommand {
-    fn command_data_mut(
-        &mut self,
-    ) -> &mut shirabe_external_packages::symfony::console::command::command::CommandData {
-        self.base_command_data.command_data_mut()
+    fn command_data(
+        &self,
+    ) -> &shirabe_external_packages::symfony::console::command::command::CommandData {
+        self.base_command_data.command_data()
     }
 
     crate::delegate_base_command_trait_impls_to_inner!(base_command_data);
-- 
cgit v1.3.1