From 4856f05e870ec5d2daaa74bf9a86a1519a813614 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Tue, 18 Aug 2026 08:37:30 +0900
Subject: fix(input): return a bool|string|string[]|null enum from get_option

`InputInterface::get_option` returned `PhpMixed`, so the negation branch
of `Input::get_option` reproduced PHP's `return !$value;` as
`!value.as_bool().unwrap_or(false)`, which inverts the result for a
string value instead of leaving it `false`. It now returns
`InputOptionValue`, whose `to_bool` is PHP's truthiness cast.

The narrowing also removes the `Vec<PhpMixed>` element handling the
commands carried for array options: `as_array` hands back `&[String]`,
so the `filter_map(|v| v.as_string())` chains at eight call sites
collapse. Its other accessors keep `PhpMixed`'s names and meanings
(`is_null`, `as_bool`, `as_string`, `to_bool`), and
`From<InputOptionValue> for PhpMixed` covers the callers that feed the
value back into an `IndexMap<String, PhpMixed>` or a `PhpMixed`
parameter.

`Input` keeps its parsed options and `InputOption` its defaults as
`PhpMixed`, so `Input::get_option` is where the narrowing happens and
where a value outside the domain panics.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/command/init_command.rs | 34 ++++++++----------------------
 1 file changed, 9 insertions(+), 25 deletions(-)

(limited to 'crates/shirabe/src/command/init_command.rs')

diff --git a/crates/shirabe/src/command/init_command.rs b/crates/shirabe/src/command/init_command.rs
index 2205b852..d1b5dbe5 100644
--- a/crates/shirabe/src/command/init_command.rs
+++ b/crates/shirabe/src/command/init_command.rs
@@ -527,12 +527,8 @@ impl Command for InitCommand {
         let repositories: Vec<String> = input
             .borrow()
             .get_option("repository")?
-            .as_list()
-            .map(|l| {
-                l.iter()
-                    .filter_map(|v| v.as_string().map(|s| s.to_string()))
-                    .collect()
-            })
+            .as_array()
+            .map(<[String]>::to_vec)
             .unwrap_or_default();
         if (repositories.len() as i64) > 0 {
             let config = std::rc::Rc::new(std::cell::RefCell::new(Factory::create_config(
@@ -790,12 +786,8 @@ impl Command for InitCommand {
             let repositories: Vec<String> = input
                 .borrow()
                 .get_option("repository")?
-                .as_list()
-                .map(|l| {
-                    l.iter()
-                        .filter_map(|v| v.as_string().map(|s| s.to_string()))
-                        .collect()
-                })
+                .as_array()
+                .map(<[String]>::to_vec)
                 .unwrap_or_default();
             if (repositories.len() as i64) > 0 {
                 let config = std::rc::Rc::new(std::cell::RefCell::new(Factory::create_config(
@@ -1048,7 +1040,7 @@ impl Command for InitCommand {
                 "Package Type (e.g. library, project, metapackage, composer-plugin) [<comment>{}</comment>]: ",
                 type_str
             ),
-            type_val,
+            type_val.into(),
         )?;
             if type_value.as_string() == Some("") || matches!(type_value, PhpMixed::Bool(false)) {
                 type_value = PhpMixed::Null;
@@ -1126,12 +1118,8 @@ impl Command for InitCommand {
             let require: Vec<String> = input
                 .borrow()
                 .get_option("require")?
-                .as_list()
-                .map(|l| {
-                    l.iter()
-                        .filter_map(|v| v.as_string().map(|s| s.to_string()))
-                        .collect()
-                })
+                .as_array()
+                .map(<[String]>::to_vec)
                 .unwrap_or_default();
             let requirements = if (require.len() as i64) > 0 || io.ask_confirmation(question, true)
             {
@@ -1156,12 +1144,8 @@ impl Command for InitCommand {
             let require_dev: Vec<String> = input
                 .borrow()
                 .get_option("require-dev")?
-                .as_list()
-                .map(|l| {
-                    l.iter()
-                        .filter_map(|v| v.as_string().map(|s| s.to_string()))
-                        .collect()
-                })
+                .as_array()
+                .map(<[String]>::to_vec)
                 .unwrap_or_default();
             let dev_requirements =
                 if (require_dev.len() as i64) > 0 || io.ask_confirmation(question, true) {
-- 
cgit v1.3.1-4-g156e