From 1e7aabcae1b2139aa20a80fbf303c74388933f55 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 15:16:07 +0900 Subject: fix(array-dumper): emit package links and require Link pretty constraint Resolve the phase-b TODO that left the supported-link-types loop as dead code (links were always an empty Vec), so requires/conflicts/provides/ replaces/require-dev are dumped again via PackageInterface::get_links_for_type, matching the PHP magic-call loop. Every Link in production is constructed with a pretty constraint (all ArrayLoader/AliasPackage/PlatformRepository/InstalledRepository sites pass one), so make Link::pretty_constraint a required String instead of Option. get_pretty_constraint() now returns &str directly rather than anyhow::Result<&str>, dropping the unreachable UnexpectedValueException guard, and all call sites are updated. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/command/package_discovery_trait.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src/command/package_discovery_trait.rs') diff --git a/crates/shirabe/src/command/package_discovery_trait.rs b/crates/shirabe/src/command/package_discovery_trait.rs index 1f2ef5b..72b635f 100644 --- a/crates/shirabe/src/command/package_discovery_trait.rs +++ b/crates/shirabe/src/command/package_discovery_trait.rs @@ -887,7 +887,7 @@ pub trait PackageDiscoveryTrait { candidate.get_pretty_name(), candidate.get_pretty_version(), link.get_target(), - link.get_pretty_constraint().unwrap_or(""), + link.get_pretty_constraint(), link.get_target(), )); } else { @@ -896,7 +896,7 @@ pub trait PackageDiscoveryTrait { candidate.get_pretty_name(), candidate.get_pretty_version(), link.get_target(), - link.get_pretty_constraint().unwrap_or(""), + link.get_pretty_constraint(), )); } continue; @@ -930,7 +930,7 @@ pub trait PackageDiscoveryTrait { candidate.get_pretty_name(), candidate.get_pretty_version(), link.get_target(), - link.get_pretty_constraint().unwrap_or(""), + link.get_pretty_constraint(), platform_pkg_version, )); } -- cgit v1.3.1