From cd25c3e193f05a5e89bca2a1c706c85fdc9c9155 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 02:13:59 +0900 Subject: refactor(repository): make read methods fallible and take &mut self Change RepositoryInterface and WritableRepositoryInterface read methods (find_package, find_packages, get_packages, load_packages, search, get_providers, get_canonical_packages) to take &mut self and return anyhow::Result, so lazy-loading repositories such as ComposerRepository can perform fallible I/O and mutate internal state on access. Update all implementors and call sites to propagate the Result and pass mutable references. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/command/reinstall_command.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src/command/reinstall_command.rs') diff --git a/crates/shirabe/src/command/reinstall_command.rs b/crates/shirabe/src/command/reinstall_command.rs index 29e8129..d183c00 100644 --- a/crates/shirabe/src/command/reinstall_command.rs +++ b/crates/shirabe/src/command/reinstall_command.rs @@ -97,7 +97,7 @@ impl ReinstallCommand { .collect() }) .unwrap_or_default(); - for package in local_repo.get_canonical_packages() { + for package in local_repo.get_canonical_packages()? { if filter_types.contains(&package.get_type()) { package_names_to_reinstall.push(package.get_name()); packages_to_reinstall.push(package); @@ -123,7 +123,7 @@ impl ReinstallCommand { for pattern in &patterns { let pattern_regexp = base_package::package_name_to_regexp(pattern); let mut matched = false; - for package in local_repo.get_canonical_packages() { + for package in local_repo.get_canonical_packages()? { if Preg::is_match(&pattern_regexp, &package.get_name()).unwrap_or(false) { matched = true; package_names_to_reinstall.push(package.get_name()); @@ -146,7 +146,7 @@ impl ReinstallCommand { uninstall_operations.push(UninstallOperation::new(package)); } - let present_packages = local_repo.get_packages(); + let present_packages = local_repo.get_packages()?; let result_packages: Vec = present_packages.iter().map(|p| p.clone().into()).collect(); let present_packages: Vec = present_packages -- cgit v1.3.1