From 0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Wed, 19 Aug 2026 23:45:37 +0900
Subject: fix(input): thread a typed InputValue through the input layer

Options and arguments were stored and passed as PhpMixed even though
Symfony only ever puts a string, a bool, a list of strings or null in
one. get_option already narrowed to InputOptionValue at the boundary;
this widens that enum into InputValue and pushes it through
InputInterface, InputOption/InputArgument defaults, the Input storage,
ArgvInput/ArrayInput/StringInput/CompletionInput, Command::add_option
and add_argument, and the Composer-side wrappers.

Two neighbouring string|int unions get types of their own:
InputDefinition::{get_argument,has_argument} take an ArgumentName, and
ArrayInput keys its parameters by ParameterName. has_parameter_option
and get_parameter_option take the values they look for as &[&str],
which is what PHP's `(array) $values` cast produced anyway.

Two behaviours change along the way. Input::set_option on a negated
option now negates with PHP's loose bool cast rather than treating a
non-bool as false, matching `!$value`. ArrayInput::parse now resolves
an integer key to an argument position instead of looking up an
argument literally named "0".

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/command/run_script_command.rs | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

(limited to 'crates/shirabe/src/command/run_script_command.rs')

diff --git a/crates/shirabe/src/command/run_script_command.rs b/crates/shirabe/src/command/run_script_command.rs
index a3a7d5be..5dc323cc 100644
--- a/crates/shirabe/src/command/run_script_command.rs
+++ b/crates/shirabe/src/command/run_script_command.rs
@@ -18,6 +18,7 @@ use shirabe_symfony_console::command::Command;
 use shirabe_symfony_console::exception::CommandNotFoundException;
 use shirabe_symfony_console::exception::NamespaceNotFoundException;
 use shirabe_symfony_console::input::InputInterface;
+use shirabe_symfony_console::input::InputValue;
 use shirabe_symfony_console::output::OutputInterface;
 
 #[derive(Debug)]
@@ -182,7 +183,7 @@ impl Command for RunScriptCommand {
             .into(),
             InputOption::new(
                 "list",
-                Some(PhpMixed::String("l".to_string())),
+                Some("l"),
                 Some(InputOption::VALUE_NONE),
                 "List scripts.",
                 None,
@@ -234,7 +235,9 @@ impl Command for RunScriptCommand {
                 false,
             )?;
 
-            input.borrow_mut().set_argument("script", script)?;
+            input
+                .borrow_mut()
+                .set_argument("script", InputValue::from_php_mixed(&script))?;
 
             Ok(())
         })();
@@ -309,12 +312,8 @@ impl Command for RunScriptCommand {
         let args: Vec<String> = input
             .borrow()
             .get_argument("args")?
-            .as_list()
-            .map(|l| {
-                l.iter()
-                    .filter_map(|v| v.as_string().map(|s| s.to_string()))
-                    .collect()
-            })
+            .as_array()
+            .map(<[String]>::to_vec)
             .unwrap_or_default();
 
         if let Some(timeout_val) = input.borrow().get_option("timeout")?.as_string() {
-- 
cgit v1.3.1-4-g156e