From 0779bfe8c7b5ee22034d552477cac54e8ae2895f Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 12 Aug 2026 01:20:25 +0900 Subject: fix(command): port ScriptAliasCommand's ignoreValidationErrors() call The command's own definition covers only --dev/--no-dev and the args array, so any other application-level option reaching it (as when GlobalCommand re-parses `--no-interaction=1` out of ArrayInput's stringification) aborted the run with "does not accept a value". Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/command/script_alias_command.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'crates/shirabe/src/command/script_alias_command.rs') diff --git a/crates/shirabe/src/command/script_alias_command.rs b/crates/shirabe/src/command/script_alias_command.rs index b10e1671..30d82779 100644 --- a/crates/shirabe/src/command/script_alias_command.rs +++ b/crates/shirabe/src/command/script_alias_command.rs @@ -44,18 +44,13 @@ impl ScriptAliasCommand { } } - // PHP also calls parent::__construct() (Symfony Command base) and - // $this->ignoreValidationErrors(). - // TODO(symfony): both are Symfony Command base-class operations — the constructor sets up - // the command's name/definition/application state and ignoreValidationErrors() flips a flag - // on it. Composer's BaseCommand carries no such Symfony Command state yet (the Symfony - // Command base is an intentional todo!() stub), so there is nothing to initialize here. let command = Self { base_command_data: BaseCommandData::new(None), script, description, aliases, }; + command.ignore_validation_errors(); command .configure() .expect("ScriptAliasCommand::configure uses constructor-provided metadata"); -- cgit v1.3.1-4-g156e