From 6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 11 Jun 2026 02:39:35 +0900 Subject: feat(console): resolve phase-b TODOs in doRun and IO wiring Wire up ConsoleIO with HelperSet/QuestionHelper, register the ErrorHandler with the IO instance, and fall back to a default output in run(). Replace resolved phase-b TODOs across the console, command, io, factory, installer, dependency_resolver, and util modules; reclassify the remaining blockers (typed Symfony command registry, stdin resource caching) as phase-c. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/command/script_alias_command.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'crates/shirabe/src/command/script_alias_command.rs') diff --git a/crates/shirabe/src/command/script_alias_command.rs b/crates/shirabe/src/command/script_alias_command.rs index ef95c7e..5c23e26 100644 --- a/crates/shirabe/src/command/script_alias_command.rs +++ b/crates/shirabe/src/command/script_alias_command.rs @@ -37,7 +37,12 @@ impl ScriptAliasCommand { } } - // TODO(phase-b): BaseCommand::new() / ignore_validation_errors() not yet ported + // PHP also calls parent::__construct() (Symfony Command base) and + // $this->ignoreValidationErrors(). + // TODO(phase-c): both are Symfony Command base-class operations — the constructor sets up + // the command's name/definition/application state and ignoreValidationErrors() flips a flag + // on it. Composer's BaseCommand carries no such Symfony Command state yet (the Symfony + // Command base is an intentional todo!() stub), so there is nothing to initialize here. Ok(Self { base_command_data: BaseCommandData { composer: None, -- cgit v1.3.1