From 436e12381dd79e419dce755718be17b66d73e17f Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 9 Jun 2026 00:09:08 +0900 Subject: feat(event-dispatcher): unify event dispatch via EventInterface trait Extract a superclass-trait EventInterface from the base Event. pool_builder's PrePoolCreateEvent stays deferred: its constructor needs owned, non-cloneable Request and repository boxes the builder only holds by reference (owned-payload blocker). The event is plugin-only, so its construction is re-tagged TODO(plugin). Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/command/show_command.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/command/show_command.rs') diff --git a/crates/shirabe/src/command/show_command.rs b/crates/shirabe/src/command/show_command.rs index 7ee103a..1ce91cb 100644 --- a/crates/shirabe/src/command/show_command.rs +++ b/crates/shirabe/src/command/show_command.rs @@ -452,7 +452,7 @@ impl ShowCommand { if let Some(ref composer) = composer { let composer = crate::command::composer_full(composer); - let command_event = CommandEvent::new6( + let mut command_event = CommandEvent::new6( PluginEvents::COMMAND, "show", input.clone(), @@ -460,13 +460,11 @@ impl ShowCommand { vec![], IndexMap::new(), ); - // TODO(phase-b): EventDispatcher::dispatch wants Option, but PHP passes - // the CommandEvent subclass directly. Phase D will introduce trait-based dispatch. - let _event_name = command_event.get_name().to_string(); + let command_event_name = command_event.get_name().to_string(); composer .get_event_dispatcher() .borrow_mut() - .dispatch(Some(&_event_name), None)?; + .dispatch(Some(&command_event_name), Some(&mut command_event))?; } if input.borrow().get_option("latest").as_bool() == Some(true) && composer.is_none() { -- cgit v1.3.1