From 4856f05e870ec5d2daaa74bf9a86a1519a813614 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Tue, 18 Aug 2026 08:37:30 +0900
Subject: fix(input): return a bool|string|string[]|null enum from get_option

`InputInterface::get_option` returned `PhpMixed`, so the negation branch
of `Input::get_option` reproduced PHP's `return !$value;` as
`!value.as_bool().unwrap_or(false)`, which inverts the result for a
string value instead of leaving it `false`. It now returns
`InputOptionValue`, whose `to_bool` is PHP's truthiness cast.

The narrowing also removes the `Vec<PhpMixed>` element handling the
commands carried for array options: `as_array` hands back `&[String]`,
so the `filter_map(|v| v.as_string())` chains at eight call sites
collapse. Its other accessors keep `PhpMixed`'s names and meanings
(`is_null`, `as_bool`, `as_string`, `to_bool`), and
`From<InputOptionValue> for PhpMixed` covers the callers that feed the
value back into an `IndexMap<String, PhpMixed>` or a `PhpMixed`
parameter.

`Input` keeps its parsed options and `InputOption` its defaults as
`PhpMixed`, so `Input::get_option` is where the narrowing happens and
where a value outside the domain panics.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/command/show_command.rs | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

(limited to 'crates/shirabe/src/command/show_command.rs')

diff --git a/crates/shirabe/src/command/show_command.rs b/crates/shirabe/src/command/show_command.rs
index 34b84fd8..3cc80b4c 100644
--- a/crates/shirabe/src/command/show_command.rs
+++ b/crates/shirabe/src/command/show_command.rs
@@ -1489,8 +1489,8 @@ impl Command for ShowCommand {
         } else if input
             .borrow()
             .get_option("ignore")?
-            .as_list()
-            .map_or(0, |l| l.len())
+            .as_array()
+            .map_or(0, <[String]>::len)
             > 0
         {
             self.get_io().write_error("<warning>You are using the option \"ignore\" for action other than \"outdated\", it will be ignored.</warning>");
@@ -2180,12 +2180,8 @@ impl Command for ShowCommand {
             &input
                 .borrow()
                 .get_option("ignore")?
-                .as_list()
-                .map(|l| {
-                    l.iter()
-                        .filter_map(|v| v.as_string().map(strtolower))
-                        .collect::<Vec<_>>()
-                })
+                .as_array()
+                .map(|l| l.iter().map(|v| strtolower(v)).collect::<Vec<_>>())
                 .unwrap_or_default(),
             "{^(?:%s)$}iD",
         );
-- 
cgit v1.3.1-4-g156e