From 3a6e69596d4f45ba1c50c6e932004e2160799d0c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 7 Jun 2026 11:03:13 +0900 Subject: feat(shirabe): resolve phase-b PhpMixed conversion TODOs Implement self-contained call sites that wrap/unwrap PhpMixed without touching shim bodies: platform-override and authentication IndexMap to PhpMixed conversions, and dev-package-name / version-alias sorts via usort with strcmp/strnatcmp. Drop stale TODO comments where the PhpMixed unwrap was already inlined. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/command/suggests_command.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/src/command/suggests_command.rs') diff --git a/crates/shirabe/src/command/suggests_command.rs b/crates/shirabe/src/command/suggests_command.rs index d050ec7..223aa6c 100644 --- a/crates/shirabe/src/command/suggests_command.rs +++ b/crates/shirabe/src/command/suggests_command.rs @@ -54,13 +54,14 @@ impl SuggestsCommand { ))]; if composer.get_locker().borrow_mut().is_locked() { - // TODO(phase-b): get_platform_overrides returns IndexMap; PlatformRepository::new expects IndexMap - let _platform_overrides = composer + let platform_overrides = composer .get_locker() .borrow_mut() .get_platform_overrides()?; - let platform_overrides: IndexMap = - todo!("convert IndexMap to IndexMap"); + let platform_overrides: IndexMap = platform_overrides + .into_iter() + .map(|(k, v)| (k, PhpMixed::String(v))) + .collect(); installed_repos.push(RepositoryInterfaceHandle::new(PlatformRepository::new( vec![], platform_overrides, -- cgit v1.3.1