From 51843230859ef39344c0b67daa9049ead87ec49c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 2 Jun 2026 23:58:38 +0900 Subject: feat(resolver): port SecurityAdvisoryPoolFilter::filter Implement the security advisory pool filter end to end, plus the remaining actionable wirings it unblocked. - Unify the PartialSecurityAdvisory|SecurityAdvisory union as the PartialOrFullSecurityAdvisory enum and make the advisory types Clone, so advisories can be collected and stored; Pool.security_removed_versions now carries the union. This also unblocks PoolOptimizer's clone of the security-removed versions. - Thread the filter result through run_security_advisory_filter/build_pool as anyhow::Result. - Introduce typed PlatformRepositoryHandle and pass platform repos as handles through determine_requirements instead of &PlatformRepository. - Wire RuleSetGenerator's is_unacceptable_fixed_or_locked_package check and UpdateCommand's non-locked installed-packages branch. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/command/update_command.rs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/command/update_command.rs') diff --git a/crates/shirabe/src/command/update_command.rs b/crates/shirabe/src/command/update_command.rs index 82f98a1..7fcfa4d 100644 --- a/crates/shirabe/src/command/update_command.rs +++ b/crates/shirabe/src/command/update_command.rs @@ -496,8 +496,6 @@ impl UpdateCommand { io_interface::NORMAL, ); let mut autocompleter_values: IndexMap = IndexMap::new(); - // TODO(phase-c): wire the non-locked branch through get_local_repository().get_packages() - // (returns Vec); only the locker branch is populated for now. let installed_packages: Vec = if composer_ref.get_locker().borrow_mut().is_locked() { CanonicalPackagesTrait::get_packages( @@ -508,12 +506,11 @@ impl UpdateCommand { .borrow(), ) } else { - let _ = composer_ref + composer_ref .get_repository_manager() .borrow() .get_local_repository() - .get_packages(); - Vec::new() + .get_packages() }; let mut version_selector = self.create_version_selector(composer)?; for package in &installed_packages { -- cgit v1.3.1