From 88b5c4b9c5f7941292b918b6eefe54947c4a0d96 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 22 Aug 2026 21:37:17 +0900 Subject: chore(todo): tag or drop the TODO markers that carry no tag MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `fund_command.rs` claimed `CompleteAliasPackage` still had to be handled, but `as_complete()` resolves through `is_complete()`, which already covers `CompleteAliasPackage` and `RootAliasPackage` — the same set PHP's `instanceof CompletePackageInterface` matches. The preceding alias guard rules those out anyway, so both markers went away; the first condition is now a single chain, matching the shape of the PHP original. `Application::find()` skips commands it cannot borrow, where Symfony registers the aliases of every command unconditionally. That is a real divergence, so it gets `TODO(port)`. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/command/fund_command.rs | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) (limited to 'crates/shirabe/src/command') diff --git a/crates/shirabe/src/command/fund_command.rs b/crates/shirabe/src/command/fund_command.rs index 9511cc31..349decf9 100644 --- a/crates/shirabe/src/command/fund_command.rs +++ b/crates/shirabe/src/command/fund_command.rs @@ -135,16 +135,14 @@ impl Command for FundCommand { // collect funding data from default branches for (_, package) in &result.packages { - if package.as_alias().is_none() { - // TODO: check for CompleteAliasPackage as well - if let Some(complete_pkg) = package.as_complete() - && complete_pkg.is_default_branch() - && !complete_pkg.get_funding().is_empty() - && packages_to_load_names.contains(&complete_pkg.get_name()) - { - Self::insert_funding_data(&mut fundings, &complete_pkg)?; - packages_to_load_names.shift_remove(&complete_pkg.get_name()); - } + if package.as_alias().is_none() + && let Some(complete_pkg) = package.as_complete() + && complete_pkg.is_default_branch() + && !complete_pkg.get_funding().is_empty() + && packages_to_load_names.contains(&complete_pkg.get_name()) + { + Self::insert_funding_data(&mut fundings, &complete_pkg)?; + packages_to_load_names.shift_remove(&complete_pkg.get_name()); } } @@ -154,7 +152,6 @@ impl Command for FundCommand { { continue; } - // TODO: check for CompleteAliasPackage as well if let Some(complete_pkg) = package.as_complete() && !complete_pkg.get_funding().is_empty() { -- cgit v1.3.1-4-g156e