From a8f115666344abe3b606a4a65595ca301e7ac08a Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 24 Jun 2026 21:10:48 +0900 Subject: refactor(process): take cwd as Option<&str> instead of IntoExecCwd Replace the generic cwd parameter backed by the IntoExecCwd trait with a concrete Option<&str> across execute/execute_args/execute_tty/execute_async. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/command/diagnose_command.rs | 2 +- crates/shirabe/src/command/home_command.rs | 10 +++++----- crates/shirabe/src/command/init_command.rs | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) (limited to 'crates/shirabe/src/command') diff --git a/crates/shirabe/src/command/diagnose_command.rs b/crates/shirabe/src/command/diagnose_command.rs index 6757d94..99118cd 100644 --- a/crates/shirabe/src/command/diagnose_command.rs +++ b/crates/shirabe/src/command/diagnose_command.rs @@ -532,7 +532,7 @@ impl DiagnoseCommand { "color.ui".to_string(), ], &mut output, - (), + None, ); if strtolower(&trim(&output, Some(" \t\n\r\0\u{0B}"))) == "always" { return "Your git color.ui setting is set to always, this is known to create issues. Use \"git config --global color.ui true\" to set it correctly.".to_string(); diff --git a/crates/shirabe/src/command/home_command.rs b/crates/shirabe/src/command/home_command.rs index b3bb3ff..081ce2d 100644 --- a/crates/shirabe/src/command/home_command.rs +++ b/crates/shirabe/src/command/home_command.rs @@ -92,22 +92,22 @@ impl HomeCommand { let _ = process.execute( PhpMixed::from(vec!["start", "\"web\"", "explorer", url]), (), - (), + None, ); return; } let linux = process - .execute(PhpMixed::from(vec!["which", "xdg-open"]), (), ()) + .execute(PhpMixed::from(vec!["which", "xdg-open"]), (), None) .unwrap_or(1); let osx = process - .execute(PhpMixed::from(vec!["which", "open"]), (), ()) + .execute(PhpMixed::from(vec!["which", "open"]), (), None) .unwrap_or(1); if linux == 0 { - let _ = process.execute(PhpMixed::from(vec!["xdg-open", url]), (), ()); + let _ = process.execute(PhpMixed::from(vec!["xdg-open", url]), (), None); } else if osx == 0 { - let _ = process.execute(PhpMixed::from(vec!["open", url]), (), ()); + let _ = process.execute(PhpMixed::from(vec!["open", url]), (), None); } else { self.get_io().write_error(&format!( "No suitable browser opening command found, open yourself: {}", diff --git a/crates/shirabe/src/command/init_command.rs b/crates/shirabe/src/command/init_command.rs index d98793a..9683b89 100644 --- a/crates/shirabe/src/command/init_command.rs +++ b/crates/shirabe/src/command/init_command.rs @@ -1010,7 +1010,7 @@ impl InitCommand { if process.execute_args( &["git".to_string(), "config".to_string(), "-l".to_string()], &mut output, - (), + None, ) == 0 { *self.git_config.borrow_mut() = Some(IndexMap::new()); -- cgit v1.3.1