From efe5bdb1987411a473d4af15451a376d20928245 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 12 Jun 2026 03:19:34 +0900 Subject: refactor(php-shim): replace literal sprintf calls with format! Convert every sprintf() call with a compile-time literal format string to format!, implementing Display for PhpMixed (delegating to php_to_string) so PhpMixed values render with PHP string semantics through {}. Also merge the format!-wrapped and conditional-literal dynamic sites into single format! calls. Genuinely runtime format strings (table styles, configurable error messages, command synopsis, progress-bar modifiers, regex-built messages) still go through sprintf. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/config/json_config_source.rs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'crates/shirabe/src/config') diff --git a/crates/shirabe/src/config/json_config_source.rs b/crates/shirabe/src/config/json_config_source.rs index a83c386..8580135 100644 --- a/crates/shirabe/src/config/json_config_source.rs +++ b/crates/shirabe/src/config/json_config_source.rs @@ -35,9 +35,9 @@ impl JsonConfigSource { if self.file.borrow().exists() { if !is_writable(self.file.borrow().get_path()) { return Err(RuntimeException { - message: sprintf( - "The file \"%s\" is not writable.", - &[PhpMixed::String(self.file.borrow().get_path().to_string())], + message: format!( + "The file \"{}\" is not writable.", + PhpMixed::String(self.file.borrow().get_path().to_string()), ), code: 0, } @@ -46,9 +46,9 @@ impl JsonConfigSource { if !Filesystem::is_readable(self.file.borrow().get_path()) { return Err(RuntimeException { - message: sprintf( - "The file \"%s\" is not readable.", - &[PhpMixed::String(self.file.borrow().get_path().to_string())], + message: format!( + "The file \"{}\" is not readable.", + PhpMixed::String(self.file.borrow().get_path().to_string()), ), code: 0, } @@ -456,9 +456,9 @@ impl ConfigSourceInterface for JsonConfigSource { } let Some(index_to_insert) = index_to_insert else { return Err(RuntimeException { - message: sprintf( - "The referenced repository \"%s\" does not exist.", - &[PhpMixed::String(reference_name.to_string())], + message: format!( + "The referenced repository \"{}\" does not exist.", + PhpMixed::String(reference_name.to_string()), ), code: 0, } -- cgit v1.3.1