From da602f1cb1d555c7826fa3d026df66b82061cda4 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 5 Aug 2026 04:07:35 +0900 Subject: test(plugin): pin a composer-normalize fixture and compare its listing The pinned plugin and its real dependency tree (nine packages, fetched by commit and verified by tree hash into the git-ignored ext/) install under both implementations, and the list/help renderings of the plugin-provided normalize command must match upstream byte for byte. The execution comparison is written but ignored: NormalizeCommand builds a second, in-process Composer instance, and the worker's proxy stubs reject native construction of the classes that path instantiates. Stale comments about the missing worker-side application are updated to the current facts. Co-Authored-By: Claude Fable 5 --- crates/shirabe/src/console/application.rs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/src/console/application.rs') diff --git a/crates/shirabe/src/console/application.rs b/crates/shirabe/src/console/application.rs index 7be18796..62e73aa9 100644 --- a/crates/shirabe/src/console/application.rs +++ b/crates/shirabe/src/console/application.rs @@ -2479,11 +2479,13 @@ impl ApplicationHandle { } // TODO(plugin): `new $dummy($script)` instantiates the // user's PHP command class in-process and registers the - // live object on this Application; hosting a PHP-owned - // command here needs a PHP-side Symfony Application and - // command proxying, neither of which exists yet. The - // shim class_exists above never recognizes user - // classes, so this arm is currently unreachable. + // live object on this Application. The worker-side + // console application and PhpCommandProxy exist now, + // but this arm is not wired to them: the class checks + // above use the shim class_exists, which never + // recognizes user classes, so the arm stays + // unreachable until the checks and the instantiation + // go through the worker. let _ = shirabe_php_shim::instantiate_class( &dummy_str, vec![PhpMixed::String(script.clone())], -- cgit v1.3.1