From 3a388b98a9aa6a14b1c7f7dc909c109cf9837800 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 16 Aug 2026 00:59:54 +0900 Subject: refactor: narrow pub(crate) items to private Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/dependency_resolver/default_policy.rs | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'crates/shirabe/src/dependency_resolver/default_policy.rs') diff --git a/crates/shirabe/src/dependency_resolver/default_policy.rs b/crates/shirabe/src/dependency_resolver/default_policy.rs index 8c1a7697..f753dc48 100644 --- a/crates/shirabe/src/dependency_resolver/default_policy.rs +++ b/crates/shirabe/src/dependency_resolver/default_policy.rs @@ -85,11 +85,7 @@ impl DefaultPolicy { if a.id() < b.id() { -1 } else { 1 } } - pub(crate) fn group_literals_by_name( - &self, - pool: &Pool, - literals: &[i64], - ) -> IndexMap> { + fn group_literals_by_name(&self, pool: &Pool, literals: &[i64]) -> IndexMap> { let mut packages: IndexMap> = IndexMap::new(); for &literal in literals { let package_name = pool.literal_to_package(literal).get_name().to_string(); @@ -98,7 +94,7 @@ impl DefaultPolicy { packages } - pub(crate) fn prune_to_best_version(&self, pool: &Pool, literals: Vec) -> Vec { + fn prune_to_best_version(&self, pool: &Pool, literals: Vec) -> Vec { if let Some(ref preferred_versions) = self.preferred_versions { let name = pool.literal_to_package(literals[0]).get_name(); if let Some(preferred_version) = preferred_versions.get(&name) { @@ -133,7 +129,7 @@ impl DefaultPolicy { best_literals } - pub(crate) fn prune_remote_aliases(&self, pool: &Pool, literals: Vec) -> Vec { + fn prune_remote_aliases(&self, pool: &Pool, literals: Vec) -> Vec { let mut has_local_alias = false; for &literal in &literals { @@ -162,7 +158,7 @@ impl DefaultPolicy { selected } - pub(crate) fn replaces(&self, source: BasePackageHandle, target: BasePackageHandle) -> bool { + fn replaces(&self, source: BasePackageHandle, target: BasePackageHandle) -> bool { for link in source.get_replaces().values() { if link.get_target() == target.get_name().as_str() { return true; -- cgit v1.3.1-4-g156e