From da6f05c12d08ac96b4286664cd8205d3fee042d8 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 7 Jun 2026 14:15:55 +0900 Subject: feat(phase-c): resolve owned-argument phase-b TODOs Replace value-by-value signature workarounds with proper ownership: - validate_json_schema: borrow JsonFile via ValidateJsonInput<&JsonFile>, restoring the dropped local auth file validation call - Auditor::audit / Solver::new / create_pool: pass cloned Rc handles and share Pool via Rc>; create_pool now takes &mut Request - MarkAlias{Installed,Uninstalled}Operation: hand over AliasPackageHandle from the alias-confirmed branch - dispatch_installer_event: clone the base Transaction (Rc-backed contents) and enable the PRE_OPERATIONS_EXEC dispatch - SuggestedPackagesReporter: share between command and installer via Rc> to mirror PHP reference semantics PrePoolCreateEvent remains a TODO: it is plugin-only and would require a speculative Rc migration of Request whose payload is never read today. --- crates/shirabe/src/dependency_resolver/local_repo_transaction.rs | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'crates/shirabe/src/dependency_resolver/local_repo_transaction.rs') diff --git a/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs b/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs index eb77add..e592741 100644 --- a/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs +++ b/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs @@ -26,4 +26,8 @@ impl LocalRepoTransaction { pub fn get_operations(&self) -> &Vec> { self.inner.get_operations() } + + pub(crate) fn to_transaction(&self) -> Transaction { + self.inner.clone() + } } -- cgit v1.3.1