From 1921f173ea219cb4b25847294d2d3fa465550fbb Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Mon, 25 May 2026 00:58:20 +0900
Subject: refactor(package): introduce Rc<RefCell<_>> handles for packages

PHP packages have reference semantics, so introduce shared-ownership
handles over an AnyPackage enum (PackageInterfaceHandle and friends)
and replace Box<dyn PackageInterface> throughout.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../dependency_resolver/operation/update_operation.rs | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

(limited to 'crates/shirabe/src/dependency_resolver/operation/update_operation.rs')

diff --git a/crates/shirabe/src/dependency_resolver/operation/update_operation.rs b/crates/shirabe/src/dependency_resolver/operation/update_operation.rs
index 2ce103b..6881782 100644
--- a/crates/shirabe/src/dependency_resolver/operation/update_operation.rs
+++ b/crates/shirabe/src/dependency_resolver/operation/update_operation.rs
@@ -3,28 +3,29 @@
 use crate::dependency_resolver::operation::OperationInterface;
 use crate::dependency_resolver::operation::SolverOperation;
 use crate::package::PackageInterface;
+use crate::package::PackageInterfaceHandle;
 use crate::package::version::VersionParser;
 
 #[derive(Debug)]
 pub struct UpdateOperation {
-    pub(crate) initial_package: Box<dyn PackageInterface>,
-    pub(crate) target_package: Box<dyn PackageInterface>,
+    pub(crate) initial_package: PackageInterfaceHandle,
+    pub(crate) target_package: PackageInterfaceHandle,
 }
 
 impl UpdateOperation {
-    pub fn new(initial: Box<dyn PackageInterface>, target: Box<dyn PackageInterface>) -> Self {
+    pub fn new(initial: PackageInterfaceHandle, target: PackageInterfaceHandle) -> Self {
         Self {
             initial_package: initial,
             target_package: target,
         }
     }
 
-    pub fn get_initial_package(&self) -> &dyn PackageInterface {
-        self.initial_package.as_ref()
+    pub fn get_initial_package(&self) -> &PackageInterfaceHandle {
+        &self.initial_package
     }
 
-    pub fn get_target_package(&self) -> &dyn PackageInterface {
-        self.target_package.as_ref()
+    pub fn get_target_package(&self) -> &PackageInterfaceHandle {
+        &self.target_package
     }
 
     pub fn format(
@@ -89,8 +90,8 @@ impl OperationInterface for UpdateOperation {
 
     fn show(&self, lock: bool) -> String {
         Self::format(
-            self.initial_package.as_ref(),
-            self.target_package.as_ref(),
+            self.initial_package.as_rc().borrow().as_package_interface(),
+            self.target_package.as_rc().borrow().as_package_interface(),
             lock,
         )
     }
-- 
cgit v1.3.1