From 9a25fcfc82b72f60facd381786ca5490acca032c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 5 Jun 2026 02:42:02 +0900 Subject: feat(dependency-resolver): share operations via Rc, drop clone_box OperationInterface::clone_box (a todo!() trait-object clone stub) is removed in favor of Rc shared ownership. All its methods are &self, so operations are immutable value objects that Rc can share; pushing the same operation into multiple lists (installer's install/uninstall splits) becomes a cheap Rc clone instead of clone_box. Box is replaced with Rc across Transaction (and its Lock/LocalRepo wrappers), Installer, PackageEvent, InstallationManager and EventDispatcher; Box::new operation constructions become Rc::new. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../shirabe/src/dependency_resolver/operation/operation_interface.rs | 4 ---- 1 file changed, 4 deletions(-) (limited to 'crates/shirabe/src/dependency_resolver/operation') diff --git a/crates/shirabe/src/dependency_resolver/operation/operation_interface.rs b/crates/shirabe/src/dependency_resolver/operation/operation_interface.rs index 3c24ff4..51b150c 100644 --- a/crates/shirabe/src/dependency_resolver/operation/operation_interface.rs +++ b/crates/shirabe/src/dependency_resolver/operation/operation_interface.rs @@ -13,10 +13,6 @@ pub trait OperationInterface: std::fmt::Debug { fn to_string(&self) -> String; - fn clone_box(&self) -> Box { - todo!() - } - fn as_install_operation(&self) -> Option<&InstallOperation> { None } -- cgit v1.3.1