From 5ab5f3b316798c1411ce8e6a7f5b091fda93589c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 22 Jun 2026 23:42:07 +0900 Subject: test: port previously-ignored Composer tests via __ test hatches Re-evaluate the reason'd #[ignore] tests under the Phase D criterion: a test is unportable ONLY if the APIs/types needed to WRITE it do not exist. A test that compiles but panics at runtime (todo!() body, a regex the regex crate cannot compile) or fails at runtime (incomplete or incorrect impl behavior) is portable -- it is written in full and marked with a reason-less #[ignore]. About 120 test functions move from reason'd #[ignore] to reason-less #[ignore] (the ported-but-not-yet-passing signal). Impl crates gain only additive __ test hatches (init_command, pool, file_downloader, package handle link setters, artifact/path repository, repository manager, svn); no existing logic changes. Tests whose required APIs genuinely do not exist (mock/reflection harness, ApplicationTester, solve() discarding SolverProblemsException, a script::Event that cannot be passed as an originating event) keep their reason'd #[ignore]. cargo check -p shirabe --tests passes. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/dependency_resolver/pool.rs | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'crates/shirabe/src/dependency_resolver/pool.rs') diff --git a/crates/shirabe/src/dependency_resolver/pool.rs b/crates/shirabe/src/dependency_resolver/pool.rs index b25f348..3ea7835 100644 --- a/crates/shirabe/src/dependency_resolver/pool.rs +++ b/crates/shirabe/src/dependency_resolver/pool.rs @@ -379,6 +379,12 @@ impl Pool { pub fn get_unacceptable_fixed_or_locked_packages(&self) -> &Vec { &self.unacceptable_fixed_or_locked_packages } + + /// For testing only: mirrors PHP `Pool implements \Countable` (`count($pool)`), + /// returning how many packages have been loaded into the pool. + pub fn __count(&self) -> i64 { + self.packages.len() as i64 + } } impl fmt::Display for Pool { -- cgit v1.3.1