From 80c2120a64ce9b989da288ce1fcf80dec5cf38c1 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 20 Aug 2026 01:54:09 +0900 Subject: perf(semver): build CompilingMatcher's cache key without allocating CompilingMatcher::match formats `;` into a fresh String on every call, including the cache hits the key exists to serve. Profiling put the formatting at 2.9 % of self time, more than the match it guards. Build the key into a reused thread-local buffer and copy it only when there is a miss to record. Taking the version as `&str` rather than `String` removes the copy the callers made for the same reason: `optimize_by_identical_dependencies` allocated one per candidate package in its innermost loop. laravel/framework require --no-install (warm cache, network disabled): instructions:u 9142799608 -> 8895247586 (-2.7 %) cycles:u 4626440169 -> 4496152041 (-2.8 %) wall (hyperfine, 25 runs) 1.239 s +- 0.014 s -> 1.227 s +- 0.016 s (-1.0 %) monolog/monolog is unchanged (102.1 ms -> 101.6 ms, within noise). composer.lock is byte-identical for both packages. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/dependency_resolver/pool.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/shirabe/src/dependency_resolver/pool.rs') diff --git a/crates/shirabe/src/dependency_resolver/pool.rs b/crates/shirabe/src/dependency_resolver/pool.rs index c12f819d..7ec6196b 100644 --- a/crates/shirabe/src/dependency_resolver/pool.rs +++ b/crates/shirabe/src/dependency_resolver/pool.rs @@ -305,7 +305,7 @@ impl Pool { if candidate_name == name { return constraint.is_none() - || CompilingMatcher::r#match(constraint.unwrap(), CmpOp::Eq, candidate_version); + || CompilingMatcher::r#match(constraint.unwrap(), CmpOp::Eq, &candidate_version); } let provides = candidate.get_provides(); -- cgit v1.3.1-4-g156e