From cd7c3fce2472656b2a1247429751e43350976677 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 19 Aug 2026 23:45:38 +0900 Subject: perf(package): hand out link maps behind Rc PackageInterface::getRequires() and friends return the array of Link objects; in PHP that is a copy-on-write array of object references, so a caller pays nothing to look at it. The port returned IndexMap by value, so every call deep-cloned the whole map, keys and constraints included. Pool building calls these accessors once per package per candidate, which put IndexMap::clone at 13.5% of `require laravel/laravel`. Store the maps as Rc> and return a handle. Callers that mutate the map clone it explicitly at the point of mutation, matching where PHP would separate the array. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/dependency_resolver/pool_optimizer.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/dependency_resolver/pool_optimizer.rs') diff --git a/crates/shirabe/src/dependency_resolver/pool_optimizer.rs b/crates/shirabe/src/dependency_resolver/pool_optimizer.rs index 5aca700e..c71feb4d 100644 --- a/crates/shirabe/src/dependency_resolver/pool_optimizer.rs +++ b/crates/shirabe/src/dependency_resolver/pool_optimizer.rs @@ -103,7 +103,7 @@ impl PoolOptimizer { } // Extract requested package requirements - for (require, constraint) in request.get_requires() { + for (require, constraint) in request.get_requires().iter() { self.extract_require_constraints_per_package(require, constraint.clone()); } @@ -258,7 +258,7 @@ impl PoolOptimizer { } if !package.get_replaces().is_empty() { - for (_, link) in package.get_replaces() { + for (_, link) in package.get_replaces().iter() { if CompilingMatcher::r#match( link.get_constraint(), CmpOp::Eq, -- cgit v1.3.1-4-g156e