From 791ef1cd465597ff43dab4216c4b00e9e4160da8 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Thu, 6 Aug 2026 06:25:10 +0900
Subject: refactor(php-shim): split in_array into strict and loose variants

---
 crates/shirabe/src/dependency_resolver/problem.rs | 26 ++++++++++-------------
 1 file changed, 11 insertions(+), 15 deletions(-)

(limited to 'crates/shirabe/src/dependency_resolver/problem.rs')

diff --git a/crates/shirabe/src/dependency_resolver/problem.rs b/crates/shirabe/src/dependency_resolver/problem.rs
index 40f21d19..b3da1e09 100644
--- a/crates/shirabe/src/dependency_resolver/problem.rs
+++ b/crates/shirabe/src/dependency_resolver/problem.rs
@@ -13,7 +13,7 @@ use indexmap::IndexMap;
 use shirabe_external_packages::composer::pcre::{CaptureKey, Preg};
 use shirabe_external_packages::symfony::console::formatter::OutputFormatter;
 use shirabe_php_shim::{
-    LogicException, PhpMixed, defined, extension_loaded, implode, in_array, loosely_compare,
+    LogicException, PhpMixed, defined, extension_loaded, implode, in_array_strict, loosely_compare,
     php_regex, phpversion, spl_object_hash, sprintf, str_replace, str_starts_with, stripos, strpos,
     strtolower, substr, substr_count, version_compare,
 };
@@ -223,15 +223,12 @@ impl Problem {
                 learned_pool,
             )?;
             let mut m: IndexMap<CaptureKey, String> = IndexMap::new();
-            let matched = if in_array(
-                PhpMixed::Int(rule_ref.get_reason()),
-                &PhpMixed::List(
-                    deduplicatable_rule_types
-                        .iter()
-                        .map(|t| PhpMixed::Int(*t))
-                        .collect(),
-                ),
-                true,
+            let matched = if in_array_strict(
+                rule_ref.get_reason(),
+                &deduplicatable_rule_types
+                    .iter()
+                    .map(|t| PhpMixed::Int(*t))
+                    .collect::<Vec<_>>(),
             ) {
                 Preg::is_match3(
                     php_regex!(
@@ -967,13 +964,12 @@ impl Problem {
                 && c.get_version() == "dev-master"
             {
                 for candidate in &packages {
-                    if in_array(
-                        PhpMixed::String(candidate.get_version().to_string()),
-                        &PhpMixed::List(vec![
+                    if in_array_strict(
+                        candidate.get_version().to_string(),
+                        &[
                             PhpMixed::String("dev-default".to_string()),
                             PhpMixed::String("dev-main".to_string()),
-                        ]),
-                        true,
+                        ],
                     ) {
                         suffix = format!(
                             " Perhaps dev-master was renamed to {}?",
-- 
cgit v1.3.1