From eea4efe87e455742ec17881ee93d8095925e8516 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Thu, 28 May 2026 22:43:11 +0900
Subject: refactor(repository): introduce Rc<RefCell<_>> handles for
 repositories

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/dependency_resolver/problem.rs | 50 ++++++++++++++---------
 1 file changed, 30 insertions(+), 20 deletions(-)

(limited to 'crates/shirabe/src/dependency_resolver/problem.rs')

diff --git a/crates/shirabe/src/dependency_resolver/problem.rs b/crates/shirabe/src/dependency_resolver/problem.rs
index 58d47f1..740909f 100644
--- a/crates/shirabe/src/dependency_resolver/problem.rs
+++ b/crates/shirabe/src/dependency_resolver/problem.rs
@@ -1127,11 +1127,14 @@ impl Problem {
 
         if available.len() > 0 {
             let mut selected: Option<&BasePackageHandle> = None;
-            // TODO(phase-c): the handle does not expose get_repository (a `RefCell`-borrowed
-            // back-reference); preferring the package from a PlatformRepository needs repository
-            // back-references on handles. Falling back to the first candidate for now.
             for pkg in &available {
-                let _ = pkg;
+                if pkg
+                    .get_repository()
+                    .map_or(false, |r| r.is::<PlatformRepository>())
+                {
+                    selected = Some(pkg);
+                    break;
+                }
             }
             if selected.is_none() {
                 selected = available.first();
@@ -1240,13 +1243,23 @@ impl Problem {
         reason: &str,
         constraint: Option<&AnyConstraint>,
     ) -> (String, String) {
-        // TODO(phase-c): selecting the next repository's packages relies on each package's
-        // repository back-reference, which the handle does not yet expose (phase-c handoff
-        // item #1). Both `next_repo_packages` and `next_repo` are blocked on that decision.
-        let _ = all_repos_packages;
-        let next_repo_packages: Vec<BasePackageHandle> = Vec::new();
-        let next_repo: Box<dyn crate::repository::RepositoryInterface> =
-            todo!("repository back-reference on handle pending (phase-c handoff item #1)");
+        let mut next_repo_packages: Vec<BasePackageHandle> = Vec::new();
+        let mut next_repo: Option<crate::repository::RepositoryInterfaceHandle> = None;
+        for package in all_repos_packages {
+            let pkg_repo = package.get_repository();
+            let same_repo = match (&next_repo, &pkg_repo) {
+                (None, _) => true,
+                (Some(nr), Some(pr)) => nr.ptr_eq(pr),
+                _ => false,
+            };
+            if same_repo {
+                next_repo_packages.push(package.clone());
+                next_repo = pkg_repo;
+            } else {
+                break;
+            }
+        }
+        let next_repo = next_repo.expect("next_repo must be set");
 
         if higher_repo_packages.len() > 0 {
             let top_package = higher_repo_packages.first().unwrap();
@@ -1274,11 +1287,7 @@ impl Problem {
             }
         }
 
-        if next_repo
-            .as_any()
-            .downcast_ref::<LockArrayRepository>()
-            .is_some()
-        {
+        if next_repo.is::<LockArrayRepository>() {
             let singular = higher_repo_packages.len() == 1;
 
             let mut suggestion = format!(
@@ -1351,10 +1360,11 @@ impl Problem {
                     constraint,
                     false
                 ),
-                // TODO(phase-c): the higher repo's name needs the handle's repository
-                // back-reference (phase-c handoff item #1); unreachable until `next_repo` above
-                // is resolved.
-                String::new(),
+                higher_repo_packages
+                    .first()
+                    .and_then(|p| p.get_repository())
+                    .map(|r| r.get_repo_name())
+                    .unwrap_or_default(),
                 reason
             ),
         )
-- 
cgit v1.3.1