From 432472808051cb4f1bb9517b858dbc810aaa5a63 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 25 Jul 2026 16:16:33 +0900 Subject: refactor: replace redundant clones with moves Co-Authored-By: Claude Opus 5 --- crates/shirabe/src/dependency_resolver/rule.rs | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) (limited to 'crates/shirabe/src/dependency_resolver/rule.rs') diff --git a/crates/shirabe/src/dependency_resolver/rule.rs b/crates/shirabe/src/dependency_resolver/rule.rs index e1572b0b..4ed8619c 100644 --- a/crates/shirabe/src/dependency_resolver/rule.rs +++ b/crates/shirabe/src/dependency_resolver/rule.rs @@ -146,7 +146,7 @@ impl Rule { _ => None, }, r if r == RULE_FIXED => match self.get_reason_data() { - ReasonData::Fixed { package } => Some(package.get_name().to_string()), + ReasonData::Fixed { package } => Some(package.get_name()), _ => None, }, r if r == RULE_PACKAGE_REQUIRES => match self.get_reason_data() { @@ -216,12 +216,7 @@ impl Rule { return true; } if !link.get_constraint().matches( - &SimpleConstraint::new( - "=".to_string(), - p.get_version().to_string(), - None, - ) - .into(), + &SimpleConstraint::new("=".to_string(), p.get_version(), None).into(), ) { return true; } @@ -256,12 +251,7 @@ impl Rule { return true; } if !constraint.matches( - &SimpleConstraint::new( - "=".to_string(), - p.get_version().to_string(), - None, - ) - .into(), + &SimpleConstraint::new("=".to_string(), p.get_version(), None).into(), ) { return true; } @@ -475,7 +465,7 @@ impl Rule { requires.push(pool.literal_to_package(*literal)); } - let text = link.get_pretty_string(source_package.clone()); + let text = link.get_pretty_string(source_package); if !requires.is_empty() { format!( "{} -> satisfiable by {}.", -- cgit v1.3.1