From 6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 11 Jun 2026 02:39:35 +0900 Subject: feat(console): resolve phase-b TODOs in doRun and IO wiring Wire up ConsoleIO with HelperSet/QuestionHelper, register the ErrorHandler with the IO instance, and fall back to a default output in run(). Replace resolved phase-b TODOs across the console, command, io, factory, installer, dependency_resolver, and util modules; reclassify the remaining blockers (typed Symfony command registry, stdin resource caching) as phase-c. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/dependency_resolver/rule2_literals.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/src/dependency_resolver/rule2_literals.rs') diff --git a/crates/shirabe/src/dependency_resolver/rule2_literals.rs b/crates/shirabe/src/dependency_resolver/rule2_literals.rs index 7db9024..39e1d4e 100644 --- a/crates/shirabe/src/dependency_resolver/rule2_literals.rs +++ b/crates/shirabe/src/dependency_resolver/rule2_literals.rs @@ -1,7 +1,5 @@ //! ref: composer/src/Composer/DependencyResolver/Rule2Literals.php -use shirabe_php_shim::PhpMixed; - use crate::dependency_resolver::{ReasonData, Rule, RuleBase}; #[derive(Debug)] @@ -12,7 +10,7 @@ pub struct Rule2Literals { } impl Rule2Literals { - pub fn new(literal1: i64, literal2: i64, reason: PhpMixed, reason_data: PhpMixed) -> Self { + pub fn new(literal1: i64, literal2: i64, reason: i64, reason_data: ReasonData) -> Self { let (literal1, literal2) = if literal1 < literal2 { (literal1, literal2) } else { @@ -20,7 +18,7 @@ impl Rule2Literals { }; Self { - inner: RuleBase::new(reason.as_int().unwrap_or(0), ReasonData::from(reason_data)), + inner: RuleBase::new(reason, reason_data), literal1, literal2, } -- cgit v1.3.1