From 3d4a0cadc950d4440251efa11b55b0bfb0afdef7 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 6 Aug 2026 04:22:46 +0900 Subject: chore: drop @param/@return tags that only restate Rust types The ported docblocks copied @param and @return straight from the PHP source. When such a tag carries nothing but a type and an argument name, the Rust signature already states it, so the line is noise. Tags whose text adds prose beyond the type are kept. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/dependency_resolver/transaction.rs | 9 --------- 1 file changed, 9 deletions(-) (limited to 'crates/shirabe/src/dependency_resolver/transaction.rs') diff --git a/crates/shirabe/src/dependency_resolver/transaction.rs b/crates/shirabe/src/dependency_resolver/transaction.rs index 4abe85d4..78037338 100644 --- a/crates/shirabe/src/dependency_resolver/transaction.rs +++ b/crates/shirabe/src/dependency_resolver/transaction.rs @@ -47,8 +47,6 @@ impl Default for Transaction { } impl Transaction { - /// @param PackageInterface[] $presentPackages - /// @param PackageInterface[] $resultPackages pub fn new( present_packages: Vec, result_packages: Vec, @@ -68,7 +66,6 @@ impl Transaction { &self.operations } - /// @param PackageInterface[] $resultPackages fn set_result_package_maps(&mut self, result_packages: Vec) { let package_sort = |a: &PackageInterfaceHandle, b: &PackageInterfaceHandle| -> i64 { // sort alias packages by the same name behind their non alias version @@ -107,7 +104,6 @@ impl Transaction { } } - /// @return OperationInterface[] pub(crate) fn calculate_operations(&mut self) -> Vec { let mut operations: Vec = vec![]; @@ -222,8 +218,6 @@ impl Transaction { /// /// These serve as a starting point to enumerate packages in a topological order despite potential cycles. /// If there are packages with a cycle on the top level the package with the lowest name gets picked - /// - /// @return array pub(crate) fn get_root_packages(&self) -> IndexMap { let mut roots: IndexMap = self .result_package_map @@ -251,7 +245,6 @@ impl Transaction { roots } - /// @return PackageInterface[] pub(crate) fn get_providers_in_result(&self, link: &Link) -> Vec { let Some(packages) = self.result_packages_by_name.get(link.get_target()) else { return vec![]; @@ -269,7 +262,6 @@ impl Transaction { /// it at least fixes the symptoms and makes usage of composer possible (again) /// in such scenarios. /// - /// @param OperationInterface[] $operations /// @return OperationInterface[] reordered operation list fn move_plugins_to_front(&self, mut operations: Vec) -> Vec { let mut dl_modifying_plugins_no_deps: Vec = vec![]; @@ -370,7 +362,6 @@ impl Transaction { /// Removals of packages should be executed before installations in /// case two packages resolve to the same path (due to custom installers) /// - /// @param OperationInterface[] $operations /// @return OperationInterface[] reordered operation list fn move_uninstalls_to_front(&self, mut operations: Vec) -> Vec { let mut uninst_ops: Vec = vec![]; -- cgit v1.3.1