From f4cad2123b2af0de72bda4ce039e16e74f163f4e Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 8 Aug 2026 22:14:12 +0900
Subject: feat(php-shim): give ported exceptions PHP's class hierarchy

Ported exceptions were flat structs reached with `downcast_ref`, so
Composer's `catch (\RuntimeException $e)` only matched the exact leaf
type and `get_class($e)` had nothing to report. Each exception now
embeds an instance of the class it extends and travels inside an
`AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and
`PhpClass::php_class_name` yields the PHP FQCN.

Dropping the `std::error::Error` impls from the exception types leaves
`AnyThrowable` as the only route into an `anyhow::Error`, so the walk
cannot be bypassed. A `no_exception_downcast` linter catches the
`downcast::<X>()` calls that would now silently answer `None`.

Three sites change behavior as a result: the `TransportException`
exit-code override reaches `MaxFileSizeExceededException`, the
`catch (\LogicException)` in findSimilar() reaches its subclasses, and
rendered exception titles carry the real class name rather than a
guess. `get_class_err()` is no longer a `todo!()`, which re-enables
FilesystemRepositoryTest::testCorruptedRepositoryFile.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/downloader/archive_downloader.rs | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

(limited to 'crates/shirabe/src/downloader/archive_downloader.rs')

diff --git a/crates/shirabe/src/downloader/archive_downloader.rs b/crates/shirabe/src/downloader/archive_downloader.rs
index 6ddf29b6..d2ee4a75 100644
--- a/crates/shirabe/src/downloader/archive_downloader.rs
+++ b/crates/shirabe/src/downloader/archive_downloader.rs
@@ -9,6 +9,7 @@ use crate::util::Filesystem;
 use crate::util::Platform;
 use indexmap::IndexMap;
 use shirabe_external_packages::symfony::finder::Finder;
+use shirabe_php_shim::Catch as _;
 use shirabe_php_shim::{
     DIRECTORY_SEPARATOR, PhpMixed, RuntimeException, bin2hex, file_exists, is_dir, random_bytes,
     realpath,
@@ -155,7 +156,7 @@ pub trait ArchiveDownloader {
                         Ok(false) => {}
                         Err(e) => {
                             // ignore error, and simply do not renameAsOne
-                            if e.downcast_ref::<RuntimeException>().is_none() {
+                            if !e.is_instanceof::<RuntimeException>() {
                                 return Err(e);
                             }
                         }
@@ -273,14 +274,11 @@ fn rename_recursively(
         );
         if is_dir(&target) {
             if !is_dir(file) {
-                return Err(RuntimeException {
-                    message: format!(
-                        "Installing {} would lead to overwriting the {} directory with a file from the package, invalid operation.",
-                        package,
-                        target.display()
-                    ),
-                    code: 0,
-                }
+                return Err(RuntimeException::new(format!(
+                    "Installing {} would lead to overwriting the {} directory with a file from the package, invalid operation.",
+                    package,
+                    target.display()
+                ))
                 .into());
             }
             rename_recursively(filesystem, package.clone(), file, &target)?;
-- 
cgit v1.3.1-4-g156e