From adf14510b00929aaee85ccb8dedf9164878a0164 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Fri, 5 Jun 2026 01:22:46 +0900
Subject: feat(downloader): wire ArchiveDownloader extraction and Path/Zip
 overrides

Implement ArchiveDownloader for Zip/Tar/Gzip/Xz/Phar/Rar so install()
extracts the archive (extract + rename) instead of doing FileDownloader's
plain file rename, and route install/prepare/cleanup through the mixin.
ArchiveDownloader::extract becomes &mut self to match the concrete
implementations.

Route ZipDownloader's bespoke download() (unzip-command static init) and
PathDownloader's symlink/junction/mirror download/install/remove through
the DownloaderInterface trait (path: String -> &str).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 crates/shirabe/src/downloader/gzip_downloader.rs | 58 +++++++++++++++---------
 1 file changed, 36 insertions(+), 22 deletions(-)

(limited to 'crates/shirabe/src/downloader/gzip_downloader.rs')

diff --git a/crates/shirabe/src/downloader/gzip_downloader.rs b/crates/shirabe/src/downloader/gzip_downloader.rs
index 0c47b67..05ac244 100644
--- a/crates/shirabe/src/downloader/gzip_downloader.rs
+++ b/crates/shirabe/src/downloader/gzip_downloader.rs
@@ -50,7 +50,39 @@ impl GzipDownloader {
         }
     }
 
-    pub(crate) async fn extract(
+    fn extract_using_ext(&self, file: &str, target_filepath: &str) {
+        let archive_file = gzopen(file, "rb");
+        let target_file = fopen(target_filepath, "wb");
+        loop {
+            let string = gzread(archive_file.clone(), 4096);
+            if string.is_empty() {
+                break;
+            }
+            fwrite(target_file.clone(), &string, Platform::strlen(&string));
+        }
+        gzclose(archive_file);
+        fclose(target_file);
+    }
+}
+
+impl ArchiveDownloader for GzipDownloader {
+    fn inner(&self) -> &FileDownloader {
+        &self.inner
+    }
+
+    fn inner_mut(&mut self) -> &mut FileDownloader {
+        &mut self.inner
+    }
+
+    fn cleanup_executed(&self) -> &IndexMap<String, bool> {
+        &self.cleanup_executed
+    }
+
+    fn cleanup_executed_mut(&mut self) -> &mut IndexMap<String, bool> {
+        &mut self.cleanup_executed
+    }
+
+    async fn extract(
         &mut self,
         package: PackageInterfaceHandle,
         file: &str,
@@ -114,20 +146,6 @@ impl GzipDownloader {
 
         Ok(None)
     }
-
-    fn extract_using_ext(&self, file: &str, target_filepath: &str) {
-        let archive_file = gzopen(file, "rb");
-        let target_file = fopen(target_filepath, "wb");
-        loop {
-            let string = gzread(archive_file.clone(), 4096);
-            if string.is_empty() {
-                break;
-            }
-            fwrite(target_file.clone(), &string, Platform::strlen(&string));
-        }
-        gzclose(archive_file);
-        fclose(target_file);
-    }
 }
 
 impl ChangeReportInterface for GzipDownloader {
@@ -171,9 +189,7 @@ impl crate::downloader::DownloaderInterface for GzipDownloader {
         path: &str,
         prev_package: Option<PackageInterfaceHandle>,
     ) -> Result<Option<PhpMixed>> {
-        self.inner
-            .prepare(r#type, package, path, prev_package)
-            .await
+        <Self as ArchiveDownloader>::prepare(self, r#type, package, path, prev_package).await
     }
 
     async fn install(
@@ -182,7 +198,7 @@ impl crate::downloader::DownloaderInterface for GzipDownloader {
         path: &str,
         output: bool,
     ) -> Result<Option<PhpMixed>> {
-        self.inner.install(package, path, output).await
+        <Self as ArchiveDownloader>::install(self, package, path, output).await
     }
 
     async fn update(
@@ -210,8 +226,6 @@ impl crate::downloader::DownloaderInterface for GzipDownloader {
         path: &str,
         prev_package: Option<PackageInterfaceHandle>,
     ) -> Result<Option<PhpMixed>> {
-        self.inner
-            .cleanup(r#type, package, path, prev_package)
-            .await
+        <Self as ArchiveDownloader>::cleanup(self, r#type, package, path, prev_package).await
     }
 }
-- 
cgit v1.3.1