From cc5d73c05a0abca2eebcc8a6afa0b1543ee49850 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 27 May 2026 00:49:33 +0900 Subject: refactor(package): pass package handles by value throughout Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/shirabe/src/downloader/hg_downloader.rs | 34 +++++++++++++------------- 1 file changed, 17 insertions(+), 17 deletions(-) (limited to 'crates/shirabe/src/downloader/hg_downloader.rs') diff --git a/crates/shirabe/src/downloader/hg_downloader.rs b/crates/shirabe/src/downloader/hg_downloader.rs index d4c53f3..7a48054 100644 --- a/crates/shirabe/src/downloader/hg_downloader.rs +++ b/crates/shirabe/src/downloader/hg_downloader.rs @@ -5,7 +5,7 @@ use crate::downloader::DownloaderInterface; use crate::downloader::VcsDownloaderBase; use crate::io::IOInterface; use crate::io::IOInterfaceImmutable; -use crate::package::PackageInterface; +use crate::package::PackageInterfaceHandle; use crate::util::Filesystem; use crate::util::Hg as HgUtils; use crate::util::ProcessExecutor; @@ -31,10 +31,10 @@ impl HgDownloader { pub(crate) async fn do_download( &self, - package: &dyn PackageInterface, + package: PackageInterfaceHandle, path: String, url: String, - prev_package: Option<&dyn PackageInterface>, + prev_package: Option, ) -> Result> { if HgUtils::get_version(&self.inner.process).is_none() { return Err(RuntimeException { @@ -49,7 +49,7 @@ impl HgDownloader { pub(crate) async fn do_install( &self, - package: &dyn PackageInterface, + package: PackageInterfaceHandle, path: String, url: String, ) -> Result> { @@ -103,8 +103,8 @@ impl HgDownloader { pub(crate) async fn do_update( &self, - initial: &dyn PackageInterface, - target: &dyn PackageInterface, + initial: PackageInterfaceHandle, + target: PackageInterfaceHandle, path: String, url: String, ) -> Result> { @@ -154,7 +154,7 @@ impl HgDownloader { pub fn get_local_changes( &self, - package: &dyn PackageInterface, + package: PackageInterfaceHandle, path: String, ) -> Option { if !std::path::Path::new(&format!("{}/.hg", path)).is_dir() { @@ -229,9 +229,9 @@ impl DownloaderInterface for HgDownloader { async fn download( &self, - _package: &dyn PackageInterface, + _package: PackageInterfaceHandle, _path: &str, - _prev_package: Option<&dyn PackageInterface>, + _prev_package: Option, _output: bool, ) -> Result> { todo!() @@ -240,16 +240,16 @@ impl DownloaderInterface for HgDownloader { async fn prepare( &self, _type: &str, - _package: &dyn PackageInterface, + _package: PackageInterfaceHandle, _path: &str, - _prev_package: Option<&dyn PackageInterface>, + _prev_package: Option, ) -> Result> { todo!() } async fn install( &self, - _package: &dyn PackageInterface, + _package: PackageInterfaceHandle, _path: &str, _output: bool, ) -> Result> { @@ -258,8 +258,8 @@ impl DownloaderInterface for HgDownloader { async fn update( &self, - _initial: &dyn PackageInterface, - _target: &dyn PackageInterface, + _initial: PackageInterfaceHandle, + _target: PackageInterfaceHandle, _path: &str, ) -> Result> { todo!() @@ -267,7 +267,7 @@ impl DownloaderInterface for HgDownloader { async fn remove( &self, - _package: &dyn PackageInterface, + _package: PackageInterfaceHandle, _path: &str, _output: bool, ) -> Result> { @@ -277,9 +277,9 @@ impl DownloaderInterface for HgDownloader { async fn cleanup( &self, _type: &str, - _package: &dyn PackageInterface, + _package: PackageInterfaceHandle, _path: &str, - _prev_package: Option<&dyn PackageInterface>, + _prev_package: Option, ) -> Result> { todo!() } -- cgit v1.3.1