From 3a388b98a9aa6a14b1c7f7dc909c109cf9837800 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 16 Aug 2026 00:59:54 +0900 Subject: refactor: narrow pub(crate) items to private Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/downloader/svn_downloader.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src/downloader/svn_downloader.rs') diff --git a/crates/shirabe/src/downloader/svn_downloader.rs b/crates/shirabe/src/downloader/svn_downloader.rs index 59916aa2..1487a710 100644 --- a/crates/shirabe/src/downloader/svn_downloader.rs +++ b/crates/shirabe/src/downloader/svn_downloader.rs @@ -23,7 +23,7 @@ use shirabe_php_shim::{ #[derive(Debug)] pub struct SvnDownloader { inner: VcsDownloaderBase, - pub(crate) cache_credentials: std::cell::Cell, + cache_credentials: std::cell::Cell, } impl_php_class!(SvnDownloader, r"Composer\Downloader\SvnDownloader"); @@ -41,7 +41,7 @@ impl SvnDownloader { } } - pub(crate) fn execute( + fn execute( &self, package: PackageInterfaceHandle, base_url: &str, @@ -67,7 +67,7 @@ impl SvnDownloader { }) } - pub(crate) async fn discard_changes(&self, path: &str) -> anyhow::Result> { + async fn discard_changes(&self, path: &str) -> anyhow::Result> { let mut output = String::new(); if self.inner.process.borrow_mut().execute_args( ["svn", "revert", "-R", "."].map(|s| s.to_string()).as_ref(), -- cgit v1.3.1-4-g156e